Better defaults for the disk cache perftest.

Better defaults for the disk cache perftest.

The defaults included were too small to meaningfully test os behaviour
on file IO; these larger defaults are much more representative, but
still create lots of smaller entries.

The IO patterns of the test are still a bit unrealistic (reads and
writes of entire entries), so that's likely a good idea for an
improvement going forward.

R=juliatuttle@chromium.org,rdsmith@chromium.org
BUG=611464
Committed: https://crrev.com/4e5bc2ec4c1c00e54cf966045def180f0e31ec18
Cr-Commit-Position: refs/heads/master@{#395330}

[gavinp, 2016-05-17 18:32:36]

rdsmith: PTAL.

juliatuttle: FYI.

[Randy Smith (Not in Mondays), 2016-05-18 16:51:07]

lgtm

https://codereview.chromium.org/1988833004/diff/1/net/disk_cache/disk_cache_p...
File net/disk_cache/disk_cache_perftest.cc (right):

https://codereview.chromium.org/1988833004/diff/1/net/disk_cache/disk_cache_p...
net/disk_cache/disk_cache_perftest.cc:96: // do single reads and writes.
nit, suggestion: Sketch out in a bit more detail in the comment what a more
realistic test would look like?

[gavinp, 2016-05-23 14:45:18]

The CQ bit was checked by gavinp@chromium.org

[gavinp, 2016-05-23 14:45:18]

The patchset sent to the CQ was uploaded after l-g-t-m from rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/1988833004/#ps40001
(title: "spacing")

[commit-bot: I haz the power, 2016-05-23 14:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988833004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988833004/40001

[commit-bot: I haz the power, 2016-05-23 15:28:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-23 15:30:34]

Description was changed from

==========
Better defaults for the disk cache perftest.

The defaults included were too small to meaningfully test os behaviour
on file IO; these larger defaults are much more representative, but
still create lots of smaller entries.

The IO patterns of the test are still a bit unrealistic (reads and
writes of entire entries), so that's likely a good idea for an
improvement going forward.

R=juliatuttle@chromium.org,rdsmith@chromium.org
BUG=611464
==========

to

==========
Better defaults for the disk cache perftest.

The defaults included were too small to meaningfully test os behaviour
on file IO; these larger defaults are much more representative, but
still create lots of smaller entries.

The IO patterns of the test are still a bit unrealistic (reads and
writes of entire entries), so that's likely a good idea for an
improvement going forward.

R=juliatuttle@chromium.org,rdsmith@chromium.org
BUG=611464

Committed: https://crrev.com/4e5bc2ec4c1c00e54cf966045def180f0e31ec18
Cr-Commit-Position: refs/heads/master@{#395330}
==========

[commit-bot: I haz the power, 2016-05-23 15:30:35]

Patchset 3 (id:??) landed as
https://crrev.com/4e5bc2ec4c1c00e54cf966045def180f0e31ec18
Cr-Commit-Position: refs/heads/master@{#395330}