Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3057)

Unified Diff: Source/devtools/front_end/ScreencastView.js

Issue 197823010: [DevTools] Add minimum size to WebInspector.View. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@splitdip2
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/ScreencastView.js
diff --git a/Source/devtools/front_end/ScreencastView.js b/Source/devtools/front_end/ScreencastView.js
index f3a7d94c2208a3eefc5f2cbbbbcef15c5a7bc05a..e80e20254b64941a661f5cf362c678179f1b68bb 100644
--- a/Source/devtools/front_end/ScreencastView.js
+++ b/Source/devtools/front_end/ScreencastView.js
@@ -36,6 +36,7 @@
WebInspector.ScreencastView = function()
{
WebInspector.VBox.call(this);
+ this.setMinimumSize(new Size(150, 150));
this.registerRequiredCSS("screencastView.css");
};
@@ -45,11 +46,6 @@ WebInspector.ScreencastView._navBarHeight = 29;
WebInspector.ScreencastView._HttpRegex = /^https?:\/\/(.+)/;
-WebInspector.ScreencastView.Constraints = {
- Width: 150,
- Height: 150
-};
-
WebInspector.ScreencastView.prototype = {
initialize: function()
{
@@ -928,15 +924,13 @@ WebInspector.ScreencastController = function()
this._rootSplitView = new WebInspector.SplitView(false, true, "InspectorView.screencastSplitViewState", 300, 300);
this._rootSplitView.show(rootView.element);
- this._rootSplitView.setSidebarElementConstraints(180, 50);
- this._rootSplitView.setMainElementConstraints(WebInspector.ScreencastView.Constraints.Width, WebInspector.ScreencastView.Constraints.Height);
WebInspector.inspectorView.show(this._rootSplitView.sidebarElement());
this._screencastView = new WebInspector.ScreencastView();
this._screencastView.show(this._rootSplitView.mainElement());
this._onStatusBarButtonStateChanged("disabled");
- rootView.show(document.body);
+ rootView.attachToBody();
this._initialized = false;
};

Powered by Google App Engine
This is Rietveld 408576698