Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: Source/devtools/front_end/Panel.js

Issue 197823010: [DevTools] Add minimum size to WebInspector.View. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@splitdip2
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/Panel.js
diff --git a/Source/devtools/front_end/Panel.js b/Source/devtools/front_end/Panel.js
index b1d35287070433c2bc232cf81c8a89c539e0158b..72284247aa73a9b4875b274e16ce91add73e50dd 100644
--- a/Source/devtools/front_end/Panel.js
+++ b/Source/devtools/front_end/Panel.js
@@ -154,12 +154,15 @@ WebInspector.PanelWithSidebarTree = function(name, defaultWidth)
WebInspector.Panel.call(this, name);
this._panelSplitView = new WebInspector.SplitView(true, false, this._panelName + "PanelSplitViewState", defaultWidth || 200);
- this._panelSplitView.setSidebarElementConstraints(Preferences.minSidebarWidth);
this._panelSplitView.show(this.element);
- var sidebarElement = this._panelSplitView.sidebarElement();
- sidebarElement.classList.add("sidebar");
- var sidebarTreeElement = sidebarElement.createChild("ol", "sidebar-tree");
+ var sidebarView = new WebInspector.VBox();
+ sidebarView.setMinimumSize(new Size(Preferences.minSidebarWidth, 25));
+ sidebarView.show(this._panelSplitView.sidebarElement());
+
+ this._sidebarElement = sidebarView.element;
+ this._sidebarElement.classList.add("sidebar");
+ var sidebarTreeElement = this._sidebarElement.createChild("ol", "sidebar-tree");
this.sidebarTree = new TreeOutline(sidebarTreeElement);
}
@@ -169,7 +172,7 @@ WebInspector.PanelWithSidebarTree.prototype = {
*/
sidebarElement: function()
{
- return this._panelSplitView.sidebarElement();
+ return this._sidebarElement;
},
/**
@@ -181,15 +184,6 @@ WebInspector.PanelWithSidebarTree.prototype = {
},
/**
- * @param {number=} minWidth
- * @param {number=} minHeight
- */
- setMainElementConstraints: function(minWidth, minHeight)
- {
- this._panelSplitView.setMainElementConstraints(minWidth, minHeight);
- },
-
- /**
* @return {!Element}
*/
defaultFocusedElement: function()

Powered by Google App Engine
This is Rietveld 408576698