Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 197813006: Reland "[chromeos/about:power] Collect cpuidle and cpufreq stats" (Closed)

Created:
6 years, 9 months ago by Siva Chandra
Modified:
6 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reland "[chromeos/about:power] Collect cpuidle and cpufreq stats" Original: https://chromiumcodereview.appspot.com/149973002 Revert: https://codereview.chromium.org/196613002/ The difference between this and the original CL is that the sysfs is read on the blocking pool via a non-member function. This avoids passing the weak ptr to blocking pool from the UI thread (as was the case in the original CL). This reverts commit 92e40737ec9a1cf806761b4c67caf688d3a1ef5e. BUG=335816 TBR=arv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256828

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1284 lines, -134 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +36 lines, -9 lines 0 comments Download
A chrome/browser/chromeos/power/cpu_data_collector.h View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/power/cpu_data_collector.cc View 1 1 chunk +421 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/power/power_data_collector.h View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/chromeos/power/power_data_collector.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/power_data_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/power.css View 1 chunk +52 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/power.html View 1 chunk +56 lines, -20 lines 0 comments Download
M chrome/browser/resources/chromeos/power.js View 19 chunks +460 lines, -82 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/power_ui.cc View 6 chunks +123 lines, -11 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Siva Chandra
6 years, 9 months ago (2014-03-12 21:19:11 UTC) #1
Daniel Erat
lgtm (assuming that the only difference from the previous iteration is making the blocking pool ...
6 years, 9 months ago (2014-03-12 23:56:10 UTC) #2
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 9 months ago (2014-03-13 00:08:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/197813006/20001
6 years, 9 months ago (2014-03-13 00:09:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 00:40:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=55063
6 years, 9 months ago (2014-03-13 00:40:06 UTC) #6
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 9 months ago (2014-03-13 00:53:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/197813006/20001
6 years, 9 months ago (2014-03-13 00:56:32 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 03:24:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-13 03:24:37 UTC) #10
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 9 months ago (2014-03-13 12:21:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/197813006/20001
6 years, 9 months ago (2014-03-13 12:22:28 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 15:05:20 UTC) #13
Message was sent while issue was closed.
Change committed as 256828

Powered by Google App Engine
This is Rietveld 408576698