Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 196613002: Revert of [chromeos/about:power] Collect cpuidle and cpufreq stats (Closed)

Created:
6 years, 9 months ago by Daniel Erat
Modified:
6 years, 9 months ago
CC:
chromium-reviews, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert of [chromeos/about:power] Collect cpuidle and cpufreq stats (https://codereview.chromium.org/149973002/) Reason for revert: Per Sadrul's comment, this causes a crash several seconds after startup. Original issue's description: > [chromeos/about:power] Collect and display cpuidle and cpufreq stats > > Salient changes introduced by this CL: > 1. PowerDataCollector collects CPU idle and CPU freq state > information. > 2. The about:power page is organized into expandable > sections. > 3. Two sections, "Idle State Data" and "Frequency State > Data" are added to the page. > 4. Plots have a legend. > > BUG=335816 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256294 TBR=snanda@chromium.org,arv@chromium.org,sivachandra@chromium.org NOTREECHECKS=true NOTRY=true BUG=335816 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -1284 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +11 lines, -38 lines 0 comments Download
D chrome/browser/chromeos/power/cpu_data_collector.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/chromeos/power/cpu_data_collector.cc View 1 chunk +0 lines, -409 lines 0 comments Download
M chrome/browser/chromeos/power/power_data_collector.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/chromeos/power/power_data_collector.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/power/power_data_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/power.css View 1 chunk +8 lines, -52 lines 0 comments Download
M chrome/browser/resources/chromeos/power.html View 1 chunk +20 lines, -56 lines 0 comments Download
M chrome/browser/resources/chromeos/power.js View 19 chunks +84 lines, -462 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/power_ui.cc View 6 chunks +11 lines, -123 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Daniel Erat
Created Revert of [chromeos/about:power] Collect cpuidle and cpufreq stats
6 years, 9 months ago (2014-03-12 02:26:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/196613002/1
6 years, 9 months ago (2014-03-12 02:31:29 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 02:36:40 UTC) #3
Message was sent while issue was closed.
Change committed as 256410

Powered by Google App Engine
This is Rietveld 408576698