Issue 197813004: Handlify PropertyAttribute lookups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197813004: Handlify PropertyAttribute lookups. (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify PropertyAttribute lookups. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19891

Patch Set 2 : addressed comment #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+237 lines, -200 lines)			Patch
M	src/api.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/contexts.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View		6 chunks	+54 lines, -32 lines	0 comments	Download
M	src/objects.cc	View	1	22 chunks	+143 lines, -133 lines	0 comments	Download
M	src/objects-inl.h	View		4 chunks	+25 lines, -20 lines	0 comments	Download
M	src/runtime.cc	View	1	6 chunks	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/197813004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/197813004/diff/1/src/runtime.cc#newcode2251 src/runtime.cc:2251: JSReceiver::GetPropertyAttribute(handle(lookup.holder()), name); LookupResult seems to ...

6 years, 9 months ago (2014-03-13 09:17:42 UTC) #2

Yang

6 years, 9 months ago (2014-03-13 11:55:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19891 (presubmit successful).

Expand Messages | Collapse Messages

Issue 197813004: Handlify PropertyAttribute lookups. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages