Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/api.cc

Issue 197813004: Handlify PropertyAttribute lookups. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/contexts.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3102 matching lines...) Expand 10 before | Expand all | Expand 10 after
3113 ENTER_V8(isolate); 3113 ENTER_V8(isolate);
3114 i::HandleScope scope(isolate); 3114 i::HandleScope scope(isolate);
3115 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3115 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3116 i::Handle<i::Object> key_obj = Utils::OpenHandle(*key); 3116 i::Handle<i::Object> key_obj = Utils::OpenHandle(*key);
3117 if (!key_obj->IsName()) { 3117 if (!key_obj->IsName()) {
3118 EXCEPTION_PREAMBLE(isolate); 3118 EXCEPTION_PREAMBLE(isolate);
3119 key_obj = i::Execution::ToString(isolate, key_obj, &has_pending_exception); 3119 key_obj = i::Execution::ToString(isolate, key_obj, &has_pending_exception);
3120 EXCEPTION_BAILOUT_CHECK(isolate, static_cast<PropertyAttribute>(NONE)); 3120 EXCEPTION_BAILOUT_CHECK(isolate, static_cast<PropertyAttribute>(NONE));
3121 } 3121 }
3122 i::Handle<i::Name> key_name = i::Handle<i::Name>::cast(key_obj); 3122 i::Handle<i::Name> key_name = i::Handle<i::Name>::cast(key_obj);
3123 PropertyAttributes result = self->GetPropertyAttribute(*key_name); 3123 PropertyAttributes result =
3124 i::JSReceiver::GetPropertyAttribute(self, key_name);
3124 if (result == ABSENT) return static_cast<PropertyAttribute>(NONE); 3125 if (result == ABSENT) return static_cast<PropertyAttribute>(NONE);
3125 return static_cast<PropertyAttribute>(result); 3126 return static_cast<PropertyAttribute>(result);
3126 } 3127 }
3127 3128
3128 3129
3129 Local<Value> v8::Object::GetPrototype() { 3130 Local<Value> v8::Object::GetPrototype() {
3130 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3131 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3131 ON_BAILOUT(isolate, "v8::Object::GetPrototype()", 3132 ON_BAILOUT(isolate, "v8::Object::GetPrototype()",
3132 return Local<v8::Value>()); 3133 return Local<v8::Value>());
3133 ENTER_V8(isolate); 3134 ENTER_V8(isolate);
(...skipping 4321 matching lines...) Expand 10 before | Expand all | Expand 10 after
7455 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 7456 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
7456 Address callback_address = 7457 Address callback_address =
7457 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 7458 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
7458 VMState<EXTERNAL> state(isolate); 7459 VMState<EXTERNAL> state(isolate);
7459 ExternalCallbackScope call_scope(isolate, callback_address); 7460 ExternalCallbackScope call_scope(isolate, callback_address);
7460 callback(info); 7461 callback(info);
7461 } 7462 }
7462 7463
7463 7464
7464 } } // namespace v8::internal 7465 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/contexts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698