Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1978083002: Rename Pending to PendingScriptBlocking. (Closed)

Created:
4 years, 7 months ago by rune
Modified:
4 years, 7 months ago
Reviewers:
Pat Meenan, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tfarina, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Pending to PendingScriptBlocking. Pending sheets in StyleEngine are either script blocking or render blocking (when they are render blocking they are simultaneously script blocking). Rename methods and members to reflect that pending sheets are script blocking where appropriate. No functional changes. R=pmeenan@chromium.org,esprehn@chromium.org BUG=481122 Committed: https://crrev.com/f28c779f856483b8c2b78965ccc591959b4bf341 Cr-Commit-Position: refs/heads/master@{#394364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978083002/1
4 years, 7 months ago (2016-05-14 07:48:59 UTC) #2
rune
4 years, 7 months ago (2016-05-14 07:49:39 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-14 09:03:57 UTC) #5
esprehn
lgtm
4 years, 7 months ago (2016-05-18 00:34:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978083002/1
4 years, 7 months ago (2016-05-18 00:35:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/192058)
4 years, 7 months ago (2016-05-18 03:20:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978083002/1
4 years, 7 months ago (2016-05-18 07:49:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 08:51:25 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 08:52:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f28c779f856483b8c2b78965ccc591959b4bf341
Cr-Commit-Position: refs/heads/master@{#394364}

Powered by Google App Engine
This is Rietveld 408576698