Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1978013002: Only run kStripe_Mode on JPEGs (Closed)

Created:
4 years, 7 months ago by scroggo_chromium
Modified:
4 years, 7 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Only run kStripe_Mode on JPEGs It was designed to test code in libjpeg-turbo. Skipping scanlines is tested more generally in other tests. BUG=skia:5307 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1978013002 Committed: https://skia.googlesource.com/skia/+/12e2f505696f283cc07ce8242e814263dd9e0950

Patch Set 1 #

Patch Set 2 : Change conditional to assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M dm/DM.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
scroggo
4 years, 7 months ago (2016-05-13 20:52:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978013002/1
4 years, 7 months ago (2016-05-13 20:55:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 21:21:56 UTC) #7
msarett
lgtm nit: This could be changed to an SkASSERT. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/dm/DMSrcSink.cpp&l=487
4 years, 7 months ago (2016-05-16 13:29:10 UTC) #8
scroggo
On 2016/05/16 13:29:10, msarett wrote: > lgtm > > nit: This could be changed to ...
4 years, 7 months ago (2016-05-16 13:50:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978013002/20001
4 years, 7 months ago (2016-05-16 13:50:26 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 16:04:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/12e2f505696f283cc07ce8242e814263dd9e0950

Powered by Google App Engine
This is Rietveld 408576698