Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: dm/DMSrcSink.cpp

Issue 1978013002: Only run kStripe_Mode on JPEGs (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Change conditional to assert Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMSrcSink.cpp
diff --git a/dm/DMSrcSink.cpp b/dm/DMSrcSink.cpp
index b1e280d289b1fcfde5af751bdf6e641b1963164f..50b5ecd3defb4c0652b0441df7fe2d2b80e49d0f 100644
--- a/dm/DMSrcSink.cpp
+++ b/dm/DMSrcSink.cpp
@@ -484,9 +484,8 @@ Error CodecSrc::draw(SkCanvas* canvas) const {
// This mode was designed to test the new skip scanlines API in libjpeg-turbo.
// Jpegs have kTopDown_SkScanlineOrder, and at this time, it is not interesting
// to run this test for image types that do not have this scanline ordering.
- if (SkCodec::kTopDown_SkScanlineOrder != codec->getScanlineOrder()) {
- return Error::Nonfatal("kStripe test is only interesting for kTopDown codecs.");
- }
+ // We only run this on Jpeg, which is always kTopDown.
+ SkASSERT(SkCodec::kTopDown_SkScanlineOrder == codec->getScanlineOrder());
for (int i = 0; i < numStripes; i += 2) {
// Skip a stripe
« no previous file with comments | « dm/DM.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698