Convert MethodMirror.returnType to native calls (and more)

runtime/vm/object.cc

Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index a16190e232dc642036467a3ff51f278fbb46b0b3..e62c2ae83a4e2943d6346ce6ce3a131a1f406ec5 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -14215,6 +14215,14 @@ void WeakProperty::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->CloseObject();
 }
 
+
+RawFunction* MirrorReference::GetFunctionReferent(RawObject* raw_ptr) {
+  const MirrorReference& ref = MirrorReference::CheckedHandle(raw_ptr);
+  ASSERT(Object::Handle(ref.referent()).IsFunction());
+  return Function::Cast(Object::Handle(ref.referent())).raw();

[siva, 2013/07/19 21:01:40]

We use CheckedHandle only in the native code methods when dealing with
parameters to native methods and also we don't normally
declare methods which take raw pointers to object as parameters.

I would change this code as follows:

RawFunction* MirrorReference::GetFunctionReferent() {
  ASSERT(Object::Handle(ref.referent()).IsFunction());
  return Function::Cast(Object::Handle(referent())).raw();
}

[Michael Lippautz (Google), 2013/07/19 22:13:20]

Done.

+}
+
+
 RawMirrorReference* MirrorReference::New(Heap::Space space) {
   ASSERT(Isolate::Current()->object_store()->mirror_reference_class()
          != Class::null());