Convert MethodMirror.returnType to native calls (and more)

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 14197 matching lines @@
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 
 void WeakProperty::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->OpenObject();
   stream->CloseObject();
 }
 
+
+RawFunction* MirrorReference::GetFunctionReferent(RawObject* raw_ptr) {
+  const MirrorReference& ref = MirrorReference::CheckedHandle(raw_ptr);
+  ASSERT(Object::Handle(ref.referent()).IsFunction());
+  return Function::Cast(Object::Handle(ref.referent())).raw();

[siva, 2013/07/19 21:01:40]

We use CheckedHandle only in the native code methods when dealing with
parameters to native methods and also we don't normally
declare methods which take raw pointers to object as parameters.

I would change this code as follows:

RawFunction* MirrorReference::GetFunctionReferent() {
  ASSERT(Object::Handle(ref.referent()).IsFunction());
  return Function::Cast(Object::Handle(referent())).raw();
}

[Michael Lippautz (Google), 2013/07/19 22:13:20]

Done.

+}
+
+
 RawMirrorReference* MirrorReference::New(Heap::Space space) {
   ASSERT(Isolate::Current()->object_store()->mirror_reference_class()
          != Class::null());
   RawObject* raw = Object::Allocate(MirrorReference::kClassId,
                                     MirrorReference::InstanceSize(),
                                     space);
   return reinterpret_cast<RawMirrorReference*>(raw);
 }
 
 
 const char* MirrorReference::ToCString() const {
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   stream->OpenObject();
   stream->CloseObject();
 }
 
 
 }  // namespace dart