Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1977993002: Give no-downloads a min-height to avoid overlapping the header. (Closed)

Created:
4 years, 7 months ago by cbiesinger
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Give no-downloads a min-height to avoid overlapping the header. Without the min-height, we will flex-shrink the container of the image and center it outside its container, overlapping the header. BUG=611334 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1978613002 Cr-Commit-Position: refs/heads/master@{#393356} (cherry picked from commit a5f745c1b2dfebd09e143a0388647f70d9e488a8) Committed: https://chromium.googlesource.com/chromium/src/+/00bee55721e37dd51e0665552750238588e7da59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/md_downloads/manager.css View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 7 months ago (2016-05-13 20:27:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00bee55721e37dd51e0665552750238588e7da59 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698