Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1978613002: Give no-downloads a min-height to avoid overlapping the header. (Closed)

Created:
4 years, 7 months ago by cbiesinger
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give no-downloads a min-height to avoid overlapping the header. Without the min-height, we will flex-shrink the container of the image and center it outside its container, overlapping the header. BUG=611334 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a5f745c1b2dfebd09e143a0388647f70d9e488a8 Cr-Commit-Position: refs/heads/master@{#393356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/resources/md_downloads/manager.css View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cbiesinger
4 years, 7 months ago (2016-05-12 20:18:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978613002/1
4 years, 7 months ago (2016-05-12 20:20:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 20:59:08 UTC) #6
Dan Beam
lgtm
4 years, 7 months ago (2016-05-12 21:07:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1978613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1978613002/1
4 years, 7 months ago (2016-05-12 21:09:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 21:13:19 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 21:16:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5f745c1b2dfebd09e143a0388647f70d9e488a8
Cr-Commit-Position: refs/heads/master@{#393356}

Powered by Google App Engine
This is Rietveld 408576698