Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Unified Diff: content/test/gpu/gpu_tests/gpu_process.py

Issue 1977953002: Prevent skip_gpu_process from running on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/gpu/page_sets/gpu_process_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/gpu_process.py
diff --git a/content/test/gpu/gpu_tests/gpu_process.py b/content/test/gpu/gpu_tests/gpu_process.py
index db5cc02fcba93df7f261d5a36588656c11d7e542..924246cb7b55c53d6ba5a7fb779bdd234f02516a 100644
--- a/content/test/gpu/gpu_tests/gpu_process.py
+++ b/content/test/gpu/gpu_tests/gpu_process.py
@@ -55,7 +55,10 @@ class GpuProcess(gpu_test_base.TestBase):
return expectations.GpuProcessExpectations()
def CreateStorySet(self, options):
- story_set = page_sets.GpuProcessTestsStorySet(self.GetExpectations())
+ browser_type = options.browser_options.browser_type
+ is_platform_android = browser_type == 'android-content-shell'
Ken Russell (switch to Gerrit) 2016/05/13 21:49:53 Should we also consider android-webview-shell?
nednguyen 2016/05/13 21:53:35 is_platform_android = browser_type.startswith('and
cblume 2016/05/13 22:01:43 That definitely fits the is_platform_android name.
cblume 2016/05/13 22:53:30 I like this idea. I'm going to go with this.
+ story_set = page_sets.GpuProcessTestsStorySet(self.GetExpectations(),
+ is_platform_android)
for page in story_set:
page.script_to_evaluate_on_commit = test_harness_script
return story_set
« no previous file with comments | « no previous file | content/test/gpu/page_sets/gpu_process_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698