Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: content/test/gpu/gpu_tests/gpu_process.py

Issue 1977953002: Prevent skip_gpu_process from running on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/test/gpu/page_sets/gpu_process_tests.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from gpu_tests import gpu_process_expectations as expectations 4 from gpu_tests import gpu_process_expectations as expectations
5 from gpu_tests import gpu_test_base 5 from gpu_tests import gpu_test_base
6 import page_sets 6 import page_sets
7 7
8 from telemetry.page import page_test 8 from telemetry.page import page_test
9 9
10 test_harness_script = r""" 10 test_harness_script = r"""
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 test = GpuProcessValidator 48 test = GpuProcessValidator
49 49
50 @classmethod 50 @classmethod
51 def Name(cls): 51 def Name(cls):
52 return 'gpu_process' 52 return 'gpu_process'
53 53
54 def _CreateExpectations(self): 54 def _CreateExpectations(self):
55 return expectations.GpuProcessExpectations() 55 return expectations.GpuProcessExpectations()
56 56
57 def CreateStorySet(self, options): 57 def CreateStorySet(self, options):
58 story_set = page_sets.GpuProcessTestsStorySet(self.GetExpectations()) 58 browser_type = options.browser_options.browser_type
59 is_platform_android = browser_type == 'android-content-shell'
Ken Russell (switch to Gerrit) 2016/05/13 21:49:53 Should we also consider android-webview-shell?
nednguyen 2016/05/13 21:53:35 is_platform_android = browser_type.startswith('and
cblume 2016/05/13 22:01:43 That definitely fits the is_platform_android name.
cblume 2016/05/13 22:53:30 I like this idea. I'm going to go with this.
60 story_set = page_sets.GpuProcessTestsStorySet(self.GetExpectations(),
61 is_platform_android)
59 for page in story_set: 62 for page in story_set:
60 page.script_to_evaluate_on_commit = test_harness_script 63 page.script_to_evaluate_on_commit = test_harness_script
61 return story_set 64 return story_set
OLDNEW
« no previous file with comments | « no previous file | content/test/gpu/page_sets/gpu_process_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698