Prevent skip_gpu_process from running on Android

Prevent skip_gpu_process from running on Android

We had previously tried to identify a way to tell if the test was being
run on Android. But when we did that, I did not explicitly set the
browser. So the browser_type passed down was 'reference'.

By simply specifying --browser android-content-shell we were able to
better detect that the platform is Android.

BUG=611629, 490984
R=kbr@chromium.org,nednguyen@google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/42b62c5291d9f31138a294d8a22965d02bb498f4
Cr-Commit-Position: refs/heads/master@{#393701}

[cblume, 2016-05-13 18:46:54]

Description was changed from

==========
Prevent skip_gpu_process from running on Android

We had previously tried to identify a way to tell if the test was being
run on Android. But when we did that, I did not explicitly set the
browser. So the browser_type passed down was 'reference'.

By simply specifying --browser android-content-shell we were able to
better detect that the platform is Android.

BUG=611629,490984
R=kbr@chromium.org,nednguyen@google.com
==========

to

==========
Prevent skip_gpu_process from running on Android

We had previously tried to identify a way to tell if the test was being
run on Android. But when we did that, I did not explicitly set the
browser. So the browser_type passed down was 'reference'.

By simply specifying --browser android-content-shell we were able to
better detect that the platform is Android.

BUG=611629,490984
R=kbr@chromium.org,nednguyen@google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[cblume, 2016-05-13 20:47:44]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 20:48:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977953002/1

[Ken Russell (switch to Gerrit), 2016-05-13 21:49:53]

Great. Thanks Ned for the advice and Chris for implementing this. LGTM

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/gpu_process.py (right):

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/gpu_process.py:59: is_platform_android = browser_type
== 'android-content-shell'
Should we also consider android-webview-shell?

[nednguyen, 2016-05-13 21:53:35]

lgtm

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/gpu_process.py (right):

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/gpu_process.py:59: is_platform_android = browser_type
== 'android-content-shell'
On 2016/05/13 21:49:53, Ken Russell wrote:
> Should we also consider android-webview-shell?

is_platform_android = browser_type.startswith('android')?

[cblume, 2016-05-13 22:01:44]

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/gpu_process.py (right):

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/gpu_process.py:59: is_platform_android = browser_type
== 'android-content-shell'
On 2016/05/13 21:49:53, Ken Russell wrote:
> Should we also consider android-webview-shell?

That definitely fits the is_platform_android name. If the variable keeps that
name, yes.

But that makes me wonder...is the skip_gpu_process test failing for
android-webview-shell? If not, maybe I should pass the browser_type string and
let the logic further down determine "on this particular browser, skip the
test".

While I'm at it...these bots aren't testing webview, are they? I asked boliu@
about if the test might be failing on webview and he seems to think these bots
used to run webview.

[commit-bot: I haz the power, 2016-05-13 22:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 22:12:44]

Dry run: This issue passed the CQ dry run.

[cblume, 2016-05-13 22:53:31]

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/gpu_process.py (right):

https://codereview.chromium.org/1977953002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/gpu_process.py:59: is_platform_android = browser_type
== 'android-content-shell'
On 2016/05/13 21:53:35, nednguyen wrote:
> On 2016/05/13 21:49:53, Ken Russell wrote:
> > Should we also consider android-webview-shell?
> 
> is_platform_android = browser_type.startswith('android')?

I like this idea.
I'm going to go with this.

[cblume, 2016-05-13 22:53:38]

The CQ bit was checked by cblume@chromium.org

[cblume, 2016-05-13 22:53:41]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1977953002/#ps20001
(title: "Changing the browser type detection to include webview.")

[commit-bot: I haz the power, 2016-05-13 22:54:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977953002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977953002/20001

[commit-bot: I haz the power, 2016-05-14 00:21:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-14 00:23:05]

Description was changed from

==========
Prevent skip_gpu_process from running on Android

We had previously tried to identify a way to tell if the test was being
run on Android. But when we did that, I did not explicitly set the
browser. So the browser_type passed down was 'reference'.

By simply specifying --browser android-content-shell we were able to
better detect that the platform is Android.

BUG=611629,490984
R=kbr@chromium.org,nednguyen@google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Prevent skip_gpu_process from running on Android

We had previously tried to identify a way to tell if the test was being
run on Android. But when we did that, I did not explicitly set the
browser. So the browser_type passed down was 'reference'.

By simply specifying --browser android-content-shell we were able to
better detect that the platform is Android.

BUG=611629,490984
R=kbr@chromium.org,nednguyen@google.com
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/42b62c5291d9f31138a294d8a22965d02bb498f4
Cr-Commit-Position: refs/heads/master@{#393701}
==========

[commit-bot: I haz the power, 2016-05-14 00:23:06]

Patchset 2 (id:??) landed as
https://crrev.com/42b62c5291d9f31138a294d8a22965d02bb498f4
Cr-Commit-Position: refs/heads/master@{#393701}