Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1977793003: Minor SVGFilterPainter cleanups (Closed)

Created:
4 years, 7 months ago by fs
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor SVGFilterPainter cleanups Simplify GraphicsContext handling in SVGFilterRecordingContext by getting rid of the paintingContext() calls, since we'll promptly replace that GraphicsContext with the recording context anyway. Get rid of the |context| local and use m_context instead. Drop the LayoutObject argument to paintFilteredContent(...) since it isn't used. Committed: https://crrev.com/f1ef6d9f2d1b1eb062a443210b72bb833374daf4 Cr-Commit-Position: refs/heads/master@{#393511}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 4 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 7 months ago (2016-05-13 10:38:57 UTC) #2
f(malita)
lgtm
4 years, 7 months ago (2016-05-13 13:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977793003/1
4 years, 7 months ago (2016-05-13 13:03:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 13:06:21 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 13:07:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1ef6d9f2d1b1eb062a443210b72bb833374daf4
Cr-Commit-Position: refs/heads/master@{#393511}

Powered by Google App Engine
This is Rietveld 408576698