third_party/WebKit/Source/platform/heap/Heap.cpp - Issue 1977783002: BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.cpp

Issue 1977783002: BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp ('k') | third_party/WebKit/Source/platform/heap/HeapPage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/Heap.cpp

diff --git a/third_party/WebKit/Source/platform/heap/Heap.cpp b/third_party/WebKit/Source/platform/heap/Heap.cpp

index 4714e246fea8c1bd1c8bfcf2c62380dd87b4bfed..346f33227e00d53297554272e1b9652f9c46cb2f 100644

--- a/third_party/WebKit/Source/platform/heap/Heap.cpp

+++ b/third_party/WebKit/Source/platform/heap/Heap.cpp

@@ -114,9 +114,6 @@ void ProcessHeap::init()

s_isLowEndDevice = base::SysInfo::IsLowEndDevice();

GCInfoTable::init();

- if (Platform::current() && Platform::current()->currentThread())

bashi 2016/05/13 09:01:58 Move this into Platform::init(). Otherwise includi

- Platform::current()->registerMemoryDumpProvider(BlinkGCMemoryDumpProvider::instance(), "BlinkGC");

}

void ProcessHeap::resetHeapCounters()

@@ -129,9 +126,6 @@ void ProcessHeap::shutdown()

{

ASSERT(!s_shutdownComplete);

- if (Platform::current() && Platform::current()->currentThread())

- Platform::current()->unregisterMemoryDumpProvider(BlinkGCMemoryDumpProvider::instance());

{

// The main thread must be the last thread that gets detached.

MutexLocker locker(ThreadHeap::allHeapsMutex());