BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

third_party/WebKit/Source/platform/heap/Heap.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 96 matching lines @@
 
 void ProcessHeap::init()
 {
     s_shutdownComplete = false;
     s_totalAllocatedSpace = 0;
     s_totalAllocatedObjectSize = 0;
     s_totalMarkedObjectSize = 0;
     s_isLowEndDevice = base::SysInfo::IsLowEndDevice();
 
     GCInfoTable::init();
-
-    if (Platform::current() && Platform::current()->currentThread())

[bashi, 2016/05/13 09:01:58]

Move this into Platform::init(). Otherwise including memory_dump_manager.h here
causes duplicate definitions of trace macros.

-        Platform::current()->registerMemoryDumpProvider(BlinkGCMemoryDumpProvider::instance(), "BlinkGC");
 }
 
 void ProcessHeap::resetHeapCounters()
 {
     s_totalAllocatedObjectSize = 0;
     s_totalMarkedObjectSize = 0;
 }
 
 void ProcessHeap::shutdown()
 {
     ASSERT(!s_shutdownComplete);
 
-    if (Platform::current() && Platform::current()->currentThread())
-        Platform::current()->unregisterMemoryDumpProvider(BlinkGCMemoryDumpProvider::instance());
-
     {
         // The main thread must be the last thread that gets detached.
         MutexLocker locker(ThreadHeap::allHeapsMutex());
         RELEASE_ASSERT(ThreadHeap::allHeaps().isEmpty());
     }
 
     GCInfoTable::shutdown();
     ASSERT(ProcessHeap::totalAllocatedSpace() == 0);
     s_shutdownComplete = true;
 }
@@ skipping 644 matching lines @@
     ProcessHeap::decreaseTotalMarkedObjectSize(m_stats.markedObjectSize());
 
     m_stats.reset();
     for (ThreadState* state : m_threads)
         state->resetHeapCounters();
 }
 
 ThreadHeap* ThreadHeap::s_mainThreadHeap = nullptr;
 
 } // namespace blink