BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

Removing indirections.

BUG=605822
Committed: https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b
Cr-Commit-Position: refs/heads/master@{#394043}

[bashi, 2016-05-13 09:01:58]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, keishi@chromium.org

[bashi, 2016-05-13 09:01:58]

PTAL?

https://codereview.chromium.org/1977783002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/Heap.cpp (left):

https://codereview.chromium.org/1977783002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/Heap.cpp:118: if (Platform::current() &&
Platform::current()->currentThread())
Move this into Platform::init(). Otherwise including memory_dump_manager.h here
causes duplicate definitions of trace macros.

[haraken, 2016-05-13 09:13:56]

But we need to keep using WebMemoryDumpProvider in other allocators in core/ and
modules/ (e.g., MemoryCache), right?

[bashi, 2016-05-13 09:35:27]

On 2016/05/13 09:13:56, haraken wrote:
> But we need to keep using WebMemoryDumpProvider in other allocators in core/
and
> modules/ (e.g., MemoryCache), right?

Probably. But I think we can remove WebProcessMemoryDump.

[haraken, 2016-05-13 09:40:15]

On 2016/05/13 09:35:27, bashi1 wrote:
> On 2016/05/13 09:13:56, haraken wrote:
> > But we need to keep using WebMemoryDumpProvider in other allocators in core/
> and
> > modules/ (e.g., MemoryCache), right?
> 
> Probably. But I think we can remove WebProcessMemoryDump.

Makes sense. LGTM.

[bashi, 2016-05-17 02:16:34]

Fixed tests. I'm going to land this.

[bashi, 2016-05-17 02:16:39]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-05-17 02:16:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1977783002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-17 02:16:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977783002/40001

[commit-bot: I haz the power, 2016-05-17 03:19:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-17 03:21:31]

Description was changed from

==========
BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

Removing indirections.

BUG=605822
==========

to

==========
BlinkGCMemoryDumpProvider should inherit from MemoryDumpProvider directly

Removing indirections.

BUG=605822

Committed: https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b
Cr-Commit-Position: refs/heads/master@{#394043}
==========

[commit-bot: I haz the power, 2016-05-17 03:21:32]

Patchset 3 (id:??) landed as
https://crrev.com/e6ac66446fcde0040623287ce049043d4a84d51b
Cr-Commit-Position: refs/heads/master@{#394043}