Make the combobox in ContentSettingBubbleContents an actual combobox.

Make the combobox in ContentSettingBubbleContents an actual combobox.
...instead of a menubutton that looks just like a combobox.

BUG=590850, 571500
Committed: https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2
Cr-Commit-Position: refs/heads/master@{#393625}

[Evan Stade, 2016-05-13 14:02:20]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 14:02:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977673002/1

[Evan Stade, 2016-05-13 14:03:02]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[commit-bot: I haz the power, 2016-05-13 14:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 14:23:20]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[msw, 2016-05-13 18:18:13]

nice; lgtm with minor nits

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
chrome/browser/ui/views/content_setting_bubble_contents.cc:324:
combobox->SetEnabled(false);
optional nit: inline the inverse of the conditional.

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
File chrome/browser/ui/views/content_setting_bubble_contents.h (right):

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
chrome/browser/ui/views/content_setting_bubble_contents.h:77: //
ui::ComboboxModel
nit: add a trailing colon

[Evan Stade, 2016-05-13 18:46:13]

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
File chrome/browser/ui/views/content_setting_bubble_contents.cc (right):

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
chrome/browser/ui/views/content_setting_bubble_contents.cc:324:
combobox->SetEnabled(false);
On 2016/05/13 18:18:13, msw wrote:
> optional nit: inline the inverse of the conditional.

Done.

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
File chrome/browser/ui/views/content_setting_bubble_contents.h (right):

https://codereview.chromium.org/1977673002/diff/1/chrome/browser/ui/views/con...
chrome/browser/ui/views/content_setting_bubble_contents.h:77: //
ui::ComboboxModel
On 2016/05/13 18:18:13, msw wrote:
> nit: add a trailing colon

Done.

[Evan Stade, 2016-05-13 18:46:18]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-05-13 18:46:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1977673002/#ps40001
(title: "fix compile")

[commit-bot: I haz the power, 2016-05-13 18:46:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977673002/40001

[commit-bot: I haz the power, 2016-05-13 20:41:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 20:44:38]

Description was changed from

==========
Make the combobox in ContentSettingBubbleContents an actual combobox.
...instead of a menubutton that looks just like a combobox.

BUG=590850,571500
==========

to

==========
Make the combobox in ContentSettingBubbleContents an actual combobox.
...instead of a menubutton that looks just like a combobox.

BUG=590850,571500

Committed: https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2
Cr-Commit-Position: refs/heads/master@{#393625}
==========

[commit-bot: I haz the power, 2016-05-13 20:44:40]

Patchset 3 (id:??) landed as
https://crrev.com/b4c886dba28f91e73e470a3737666501043f8cf2
Cr-Commit-Position: refs/heads/master@{#393625}