chrome/chrome_browser_ui.gypi - Issue 1977673002: Make the combobox in ContentSettingBubbleContents an actual combobox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 1977673002: Make the combobox in ContentSettingBubbleContents an actual combobox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 76ffca9b64eb3213dd51924bfeb8ff90cbd0a5e4..e831de4cbf97a17eadc8a039082a31a3e96c1ef2 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -1290,6 +1290,10 @@

'browser/ui/cocoa/website_settings/website_settings_utils_cocoa.mm',

'browser/ui/cocoa/window_size_autosaver.h',

'browser/ui/cocoa/window_size_autosaver.mm',

+ # TODO(estade): this class should be deleted in favor of a combobox model.

+ # See crbug.com/590850

+ 'browser/ui/content_settings/content_setting_media_menu_model.cc',

+ 'browser/ui/content_settings/content_setting_media_menu_model.h',

# Files used only on desktop systems (not iOS, Android, ChromeOS).

'chrome_browser_ui_desktop_sources': [

@@ -1589,8 +1593,6 @@

'browser/ui/content_settings/content_setting_bubble_model_delegate.h',

'browser/ui/content_settings/content_setting_image_model.cc',

'browser/ui/content_settings/content_setting_image_model.h',

- 'browser/ui/content_settings/content_setting_media_menu_model.cc',

- 'browser/ui/content_settings/content_setting_media_menu_model.h',

'browser/ui/exclusive_access/exclusive_access_bubble.cc',

'browser/ui/exclusive_access/exclusive_access_bubble.h',

'browser/ui/exclusive_access/exclusive_access_bubble_type.cc',

« no previous file with comments | « chrome/browser/ui/views/content_setting_bubble_contents.cc ('k') | no next file » | no next file with comments »