Issue 197763009: Remove "-t -t" -- is this causing us to hang?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197763009: Remove "-t -t" -- is this causing us to hang? (Closed)

Created:
6 years, 9 months ago by borenet

Modified:
6 years, 9 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/buildbot.git@master

Visibility:
Public.

More Reviews

Description

Remove "-t -t" -- is this causing us to hang? TBR=epoger BUG=skia:1329 Committed: https://skia.googlesource.com/buildbot/+/02cade1

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	site_config/slave_hosts_cfg.py	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

borenet

Committed patchset #1 manually as r02cade1 (presubmit successful).

6 years, 9 months ago (2014-03-13 19:20:59 UTC) #1

borenet

On 2014/03/13 19:23:35, epoger wrote: > LGTM > > Wow. Good find. What's interesting is ...

6 years, 9 months ago (2014-03-13 19:25:13 UTC) #4

epoger

6 years, 9 months ago (2014-03-13 19:32:03 UTC) #5

Message was sent while issue was closed.

On 2014/03/13 19:25:13, borenet wrote:
> On 2014/03/13 19:23:35, epoger wrote:
> > LGTM
> > 
> > Wow.  Good find.
> 
> What's interesting is that, after I added in the blocking call, I noticed that
> the gcutil commands were completing and the first "ssh -t -t" command hung,
even
> though when it looked like the gcutil commands were hanging.

Perhaps an output buffer not getting flushed...

Expand Messages | Collapse Messages