site_config/slave_hosts_cfg.py - Issue 197763009: Remove "-t -t" -- is this causing us to hang?

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: site_config/slave_hosts_cfg.py

Issue 197763009: Remove "-t -t" -- is this causing us to hang? (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: site_config/slave_hosts_cfg.py

diff --git a/site_config/slave_hosts_cfg.py b/site_config/slave_hosts_cfg.py

index b168d9752143ac7a9b4f0b842d64c99f5d13fced..4bc5e5c6df6012588a7c1cc575ec5a761d405831 100644

--- a/site_config/slave_hosts_cfg.py

+++ b/site_config/slave_hosts_cfg.py

@@ -44,10 +44,8 @@ SKIALAB_USERNAME = skia_vars.GetGlobalVariable('skialab_username')

def skia_lab_login(hostname, config):

"""Procedure for logging into SkiaLab machines."""

- # The multiple "-t"s are needed in order to force tty allocation, which gives

- # us the expected interactive behavior, even with two levels of SSH.

return [

- 'ssh', '-t', '-t', '%s@%s' % (SKIALAB_USERNAME, SKIALAB_ROUTER_IP),

+ 'ssh', '%s@%s' % (SKIALAB_USERNAME, SKIALAB_ROUTER_IP),

'ssh', '%s@%s' % (SKIALAB_USERNAME, config['ip'])

]

« no previous file with comments | « no previous file | no next file » | no next file with comments »