Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 19776013: WebCrypto: Refactor the WebCryptoOperation interface to support errors. (Closed)

Created:
7 years, 5 months ago by eroman
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

WebCrypto: Refactor the WebCryptoOperation interface to support errors. This allows the embedder to: (1) Throw an error during initialization of the CryptoOperation (which will result in throwing an exception to Javascript) (2) Terminate the CryptoOperation with an error at any point after successful initialization. This error will be delivered via the Promise's reject handler. The previous interface only allowed completing with an error during finish(), so any errors encountered during process() would have to be buffered until the end. BUG=245025 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154563

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix assertion #

Patch Set 5 : Rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -99 lines) Patch
M LayoutTests/crypto/digest.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/crypto/digest-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/CryptoOperation.h View 1 2 3 4 4 chunks +13 lines, -7 lines 0 comments Download
M Source/modules/crypto/CryptoOperation.cpp View 1 2 3 4 5 chunks +59 lines, -26 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 1 2 3 4 4 chunks +64 lines, -26 lines 0 comments Download
M public/platform/WebCrypto.h View 1 2 2 chunks +50 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
7 years, 5 months ago (2013-07-19 00:28:47 UTC) #1
abarth-chromium
LGTM
7 years, 5 months ago (2013-07-19 02:11:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/19776013/8001
7 years, 5 months ago (2013-07-19 07:17:58 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/modules/crypto/CryptoOperation.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-19 07:18:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/19776013/11002
7 years, 5 months ago (2013-07-19 07:49:35 UTC) #5
eroman
7 years, 5 months ago (2013-07-19 09:20:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r154563 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698