WebCrypto: Refactor the WebCryptoOperation interface to support errors.

Source/modules/crypto/CryptoOperation.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/crypto/CryptoOperation.h"
 
 #include "bindings/v8/custom/V8ArrayBufferCustom.h" // MUST precede ScriptPromiseResolver for compilation to work.
 #include "bindings/v8/ScriptPromiseResolver.h"
+#include "core/dom/ExceptionCode.h"
 #include "modules/crypto/Algorithm.h"
 #include "public/platform/WebArrayBuffer.h"
 #include "public/platform/WebCrypto.h"
 #include "wtf/ArrayBuffer.h"
 #include "wtf/ArrayBufferView.h"
 
 namespace WebCore {
 
-class CryptoOperation::Result : public WebKit::WebCryptoOperationResult {
-public:
-    explicit Result(CryptoOperation* parent) : m_parent(parent) { }
-
-    virtual void setArrayBuffer(const WebKit::WebArrayBuffer& buffer) OVERRIDE
-    {
-        ASSERT(m_parent->m_state == Finishing);
-        m_parent->m_state = Done;
-        m_parent->m_impl = 0;
-
-        m_parent->promiseResolver()->fulfill(PassRefPtr<ArrayBuffer>(buffer));
-    }
-
-private:
-    CryptoOperation* m_parent;
-};
-
 CryptoOperation::~CryptoOperation()
 {
     abortImpl();
     ASSERT(!m_impl);
 }
 
-PassRefPtr<CryptoOperation> CryptoOperation::create(const WebKit::WebCryptoAlgorithm& algorithm, WebKit::WebCryptoOperation* impl)
+PassRefPtr<CryptoOperation> CryptoOperation::create(const WebKit::WebCryptoAlgorithm& algorithm, ExceptionCode* ec)
 {
-    return adoptRef(new CryptoOperation(algorithm, impl));
+    return adoptRef(new CryptoOperation(algorithm, ec));
 }
 
-CryptoOperation::CryptoOperation(const WebKit::WebCryptoAlgorithm& algorithm, WebKit::WebCryptoOperation* impl)
+CryptoOperation::CryptoOperation(const WebKit::WebCryptoAlgorithm& algorithm, ExceptionCode* ec)
     : m_algorithm(algorithm)
-    , m_impl(impl)
-    , m_state(Processing)
-    , m_result(adoptPtr(new Result(this)))
+    , m_impl(0)
+    , m_exceptionCode(ec)
+    , m_state(Initializing)
 {
-    ASSERT(impl);
+    ASSERT(ec);
     ScriptWrappable::init(this);
 }
 
 CryptoOperation* CryptoOperation::process(ArrayBuffer* data)
 {
     process(static_cast<unsigned char*>(data->data()), data->byteLength());
     return this;
 }
 
 CryptoOperation* CryptoOperation::process(ArrayBufferView* data)
 {
     process(static_cast<unsigned char*>(data->baseAddress()), data->byteLength());
     return this;
 }
 
 ScriptObject CryptoOperation::finish()
 {
     switch (m_state) {
+    case Initializing:
+        ASSERT_NOT_REACHED();
+        return ScriptObject();
     case Processing:
         m_state = Finishing;
         // NOTE: The following line can result in re-entrancy to |this|
-        m_impl->finish(m_result.get());
+        m_impl->finish();
         break;
     case Finishing:
         // Calling finish() twice is a no-op.
         break;
     case Done:
         // Calling finish() after already complete is a no-op.
         ASSERT(!m_impl);
         break;
     }
 
     return promiseResolver()->promise();
 }
 
 ScriptObject CryptoOperation::abort()
 {
     if (abortImpl())
         promiseResolver()->reject(ScriptValue::createNull());
     return promiseResolver()->promise();
 }
 
 Algorithm* CryptoOperation::algorithm()
 {
     if (!m_algorithmNode)
         m_algorithmNode = Algorithm::create(m_algorithm);
     return m_algorithmNode.get();
 }
 
+void CryptoOperation::initializationFailed()
+{
+    ASSERT(m_state == Initializing);
+
+    *m_exceptionCode = NotSupportedError;
+
+    m_exceptionCode = 0;
+    m_state = Done;
+}
+
+void CryptoOperation::initializationSucceded(WebKit::WebCryptoOperation* operationImpl)
+{
+    ASSERT(m_state == Initializing);
+    ASSERT(operationImpl);
+    ASSERT(!m_impl);
+
+    m_exceptionCode = 0;
+    m_impl = operationImpl;
+    m_state = Processing;
+}
+
+void CryptoOperation::completeWithError()
+{
+    ASSERT(m_state == Processing || m_state == Finishing);
+
+    m_impl = 0;
+    m_state = Done;
+
+    promiseResolver()->reject(ScriptValue::createNull());
+}
+
+void CryptoOperation::completeWithArrayBuffer(const WebKit::WebArrayBuffer& buffer)
+{
+    ASSERT(m_state == Processing || m_state == Finishing);
+
+    m_impl = 0;
+    m_state = Done;
+
+    promiseResolver()->fulfill(PassRefPtr<ArrayBuffer>(buffer));
+}
+
 void CryptoOperation::process(const unsigned char* bytes, size_t size)
 {
     switch (m_state) {
+    case Initializing:
+        ASSERT_NOT_REACHED();
     case Processing:
         m_impl->process(bytes, size);
         break;
     case Finishing:
     case Done:
         return;
     }
 }
 
 bool CryptoOperation::abortImpl()
 {
     switch (m_state) {
+    case Initializing:
+        ASSERT_NOT_REACHED();
+        break;
     case Processing:
     case Finishing:
         // This will cause m_impl to be deleted.
+        m_state = Done;
         m_impl->abort();
-        m_state = Done;
         m_impl = 0;
         return true;
     case Done:
         ASSERT(!m_impl);
         break;
     }
 
     return false;
 }
 
 ScriptPromiseResolver* CryptoOperation::promiseResolver()
 {
     if (!m_promiseResolver)
         m_promiseResolver = ScriptPromiseResolver::create();
     return m_promiseResolver.get();
 }
 
 } // namespace WebCore