MacViews: add extension install dialog to MacViewsWebUIDialogs

chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc
diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a72477441832e94b725a585164c87941d89efe04
--- /dev/null
+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc
@@ -0,0 +1,11 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_install_prompt.h"
+
+// static
+ExtensionInstallPrompt::ShowDialogCallback
+ExtensionInstallPrompt::GetDefaultShowDialogCallback() {

[tapted, 2016/05/13 07:42:08]

Can this go in chrome/browser/ui/views/browser_dialog_views.cc ? There's a
comment in that file:

// This file provides definitions of desktop browser dialog-creation methods for
// all toolkit-views platforms other than Mac. It also provides the definitions
// on Mac when mac_views_browser=1

I think that's the right fit for this. It's fine to #include
chrome/browser/ui/views/extensions/extension_install_dialog_view.h there, and I
think Views \implies{} extensions, so there's no need to wrap it in #if
defined(ENABLE_EXTENSIONS)

[tapted, 2016/05/13 07:54:57]

oops ignore just this part of the comment -
"chrome/browser/extensions/extension_install_prompt.h" is the one you'll want,
so that the Cocoa file can get at it too.

[Elly Fong-Jones, 2016/05/13 21:41:51]

Done.

+  return ExtensionInstallPrompt::GetViewsShowDialogCallback();
+}