chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc - Issue 1977593002: MacViews: add extension install dialog to MacViewsWebUIDialogs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_shim.cc

Issue 1977593002: MacViews: add extension install dialog to MacViewsWebUIDialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_install_prompt.h ('K') | « chrome/browser/ui/views/extensions/extension_install_dialog_view.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | chrome/chrome_browser_ui.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/extensions/extension_install_prompt.h"

	6

	7 // static

	8 ExtensionInstallPrompt::ShowDialogCallback

	9 ExtensionInstallPrompt::GetDefaultShowDialogCallback() {
	tapted 2016/05/13 07:42:08 Can this go in chrome/browser/ui/views/browser_dia Can this go in chrome/browser/ui/views/browser_dialog_views.cc ? There's a comment in that file: // This file provides definitions of desktop browser dialog-creation methods for // all toolkit-views platforms other than Mac. It also provides the definitions // on Mac when mac_views_browser=1 I think that's the right fit for this. It's fine to #include chrome/browser/ui/views/extensions/extension_install_dialog_view.h there, and I think Views \implies{} extensions, so there's no need to wrap it in #if defined(ENABLE_EXTENSIONS) tapted 2016/05/13 07:54:57 oops ignore just this part of the comment - "chrom Show quoted text On 2016/05/13 07:42:08, tapted wrote: > t's fine to #include > chrome/browser/ui/views/extensions/extension_install_dialog_view.h [in chrome/browser/ui/views/browser_dialog_views.cc] oops ignore just this part of the comment - "chrome/browser/extensions/extension_install_prompt.h" is the one you'll want, so that the Cocoa file can get at it too. Elly Fong-Jones 2016/05/13 21:41:51 Done. Show quoted text On 2016/05/13 07:54:57, tapted wrote: > On 2016/05/13 07:42:08, tapted wrote: > > t's fine to #include > > chrome/browser/ui/views/extensions/extension_install_dialog_view.h [in > chrome/browser/ui/views/browser_dialog_views.cc] > > oops ignore just this part of the comment - > "chrome/browser/extensions/extension_install_prompt.h" is the one you'll want, > so that the Cocoa file can get at it too. Done.
	10 return ExtensionInstallPrompt::GetViewsShowDialogCallback();

	11 }

OLD	NEW