Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1977513003: Get rid of assertions on socket pools in HttpStreamFactoryBidirectionalQuicTest (Closed)

Created:
4 years, 7 months ago by xunjieli
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of assertions on socket pools in HttpStreamFactoryBidirectionalQuicTest This CL get rid of the assertions on socket pools in RequestBidirectionalStreamImplQuicAlternative and RequestBidirectionalStreamImplHttpJobFailsQuicJobSucceeds unit test. The assertions are flaky on Dr Memory bots. This is probably because even though we add hanging mock socket data for H2, TCP socket pools sometimes do get established. BUG=611533

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M net/http/http_stream_factory_impl_unittest.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xunjieli
Ryan, PTAL. Thanks!
4 years, 7 months ago (2016-05-12 21:12:18 UTC) #3
xunjieli
On 2016/05/12 21:12:18, xunjieli wrote: > Ryan, PTAL. Thanks! Ping!
4 years, 7 months ago (2016-05-18 13:48:50 UTC) #5
Ryan Hamilton
I don't think I understand what makes these assertions flaky on the bots. Why do ...
4 years, 7 months ago (2016-05-19 19:38:32 UTC) #6
xunjieli
On 2016/05/19 19:38:32, Ryan Hamilton wrote: > I don't think I understand what makes these ...
4 years, 7 months ago (2016-05-20 17:07:58 UTC) #7
Ryan Hamilton
On 2016/05/20 17:07:58, xunjieli wrote: > On 2016/05/19 19:38:32, Ryan Hamilton wrote: > > I ...
4 years, 7 months ago (2016-05-20 20:47:47 UTC) #8
xunjieli
4 years, 7 months ago (2016-05-20 20:53:15 UTC) #9
On 2016/05/20 20:47:47, Ryan Hamilton wrote:
> On 2016/05/20 17:07:58, xunjieli wrote:
> > On 2016/05/19 19:38:32, Ryan Hamilton wrote:
> > > I don't think I understand what makes these assertions flaky on the bots.
> Why
> > do
> > > the unexpected sockets get created? Would it be possible to disable these
> > > expectations only for those bots? 
> > 
> > I was hoping you might know why the TCP sockets get created. I do not know
> > either :) These assertions are not crucial to the tests, so I thought that I
> > would just get rid of them. But since these two tests are already disabled
on
> > these DrMemory bots, I am happy to abandon this CL instead. WDYT?
> 
> Heh, works for me.

Thanks. I will WontFix on the crbug then.

Powered by Google App Engine
This is Rietveld 408576698