Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 1977513003: Get rid of assertions on socket pools in HttpStreamFactoryBidirectionalQuicTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_unittest.cc
diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc
index 348a94e0264866ea56e05ca265898c1b7ec0500a..c552c0e5c9ab2a2760d1109a828a387a850096d2 100644
--- a/net/http/http_stream_factory_impl_unittest.cc
+++ b/net/http/http_stream_factory_impl_unittest.cc
@@ -1641,14 +1641,6 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
EXPECT_EQ(OK, stream_impl->ReadData(buffer.get(), 1));
EXPECT_EQ(kProtoQUIC1SPDY3, stream_impl->GetProtocol());
EXPECT_EQ("200", delegate.response_headers().find(":status")->second);
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetTransportSocketPool(
- HttpNetworkSession::NORMAL_SOCKET_POOL)));
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetSSLSocketPool(
- HttpNetworkSession::NORMAL_SOCKET_POOL)));
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetTransportSocketPool(
- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetSSLSocketPool(
- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
EXPECT_TRUE(waiter.used_proxy_info().is_direct());
}
@@ -1768,15 +1760,6 @@ TEST_P(HttpStreamFactoryBidirectionalQuicTest,
EXPECT_EQ(OK, stream_impl->ReadData(buffer.get(), 1));
EXPECT_EQ(kProtoQUIC1SPDY3, stream_impl->GetProtocol());
EXPECT_EQ("200", delegate.response_headers().find(":status")->second);
- // There is no Http2 socket pool.
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetTransportSocketPool(
- HttpNetworkSession::NORMAL_SOCKET_POOL)));
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetSSLSocketPool(
- HttpNetworkSession::NORMAL_SOCKET_POOL)));
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetTransportSocketPool(
- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
- EXPECT_EQ(0, GetSocketPoolGroupCount(session()->GetSSLSocketPool(
- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));
EXPECT_TRUE(waiter.used_proxy_info().is_direct());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698