Disable input scaling only when an input came from renderer

Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes the issue by only skip scaling when events are sent back from renderer.

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/cbcc58292dabf419324cddbad21242ddc8be3896
Cr-Commit-Position: refs/heads/master@{#394499}

[oshima, 2016-05-12 16:20:37]

Description was changed from

==========
Disable input scaling when an input came from renderer

BUG=
==========

to

==========
Disable input scaling when an input came from renderer

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[oshima, 2016-05-12 16:21:08]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 16:21:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/1

[oshima, 2016-05-12 16:21:46]

Description was changed from

==========
Disable input scaling when an input came from renderer

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable input scaling when an input came from renderer

BUG=485650
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-05-12 16:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 16:48:41]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[oshima, 2016-05-12 17:48:51]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 17:49:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/1

[commit-bot: I haz the power, 2016-05-12 18:19:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 18:19:25]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[oshima, 2016-05-12 18:45:37]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 18:45:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/20001

[oshima, 2016-05-12 18:56:49]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 18:57:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/40001

[oshima, 2016-05-12 20:38:10]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 20:38:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/60001

[commit-bot: I haz the power, 2016-05-12 20:51:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 20:51:13]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[oshima, 2016-05-13 17:05:11]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 17:05:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/100001

[oshima, 2016-05-13 17:55:35]

Description was changed from

==========
Disable input scaling when an input came from renderer

BUG=485650
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable input scaling only when an input came from renderer

BUG=485650
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[oshima, 2016-05-13 17:55:35]

oshima@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[oshima, 2016-05-13 17:55:44]

Patchset #1 (id:1) has been deleted

[oshima, 2016-05-13 17:55:50]

Patchset #1 (id:20001) has been deleted

[oshima, 2016-05-13 17:55:56]

Patchset #2 (id:60001) has been deleted

[oshima, 2016-05-13 17:56:03]

Patchset #1 (id:40001) has been deleted

[oshima, 2016-05-13 17:56:09]

Patchset #1 (id:80001) has been deleted

[oshima, 2016-05-13 18:01:11]

Description was changed from

==========
Disable input scaling only when an input came from renderer

BUG=485650
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable input scaling only when an input came from renderer

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[oshima, 2016-05-13 18:02:03]

Description was changed from

==========
Disable input scaling only when an input came from renderer

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes
the issue by only skip scaling when events are sent back from renderer.

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2016-05-13 18:17:57]

LGTM, with one comment.

https://codereview.chromium.org/1977513002/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/1977513002/diff/100001/content/browser/frame_...
content/browser/frame_host/render_widget_host_view_guest.cc:169: LOG(ERROR) <<
"Touch Event:" << WebInputEventTraits::ToString(event);
I'm not sure I understand what this is here for?

[oshima, 2016-05-13 18:47:04]

https://codereview.chromium.org/1977513002/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_widget_host_view_guest.cc (right):

https://codereview.chromium.org/1977513002/diff/100001/content/browser/frame_...
content/browser/frame_host/render_widget_host_view_guest.cc:169: LOG(ERROR) <<
"Touch Event:" << WebInputEventTraits::ToString(event);
On 2016/05/13 18:17:57, wjmaclean wrote:
> I'm not sure I understand what this is here for?
Oops, sorry. It's was just debug message. Removed.

[oshima, 2016-05-13 18:47:31]

oshima@chromium.org changed reviewers:
+ sievers@chromium.org

[oshima, 2016-05-13 18:47:48]

sievers@ -> owners review

[oshima, 2016-05-13 18:47:54]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 18:48:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/120001

[wjmaclean, 2016-05-13 18:50:59]

On 2016/05/13 18:47:04, oshima wrote:
>
https://codereview.chromium.org/1977513002/diff/100001/content/browser/frame_...
> File content/browser/frame_host/render_widget_host_view_guest.cc (right):
> 
>
https://codereview.chromium.org/1977513002/diff/100001/content/browser/frame_...
> content/browser/frame_host/render_widget_host_view_guest.cc:169: LOG(ERROR) <<
> "Touch Event:" << WebInputEventTraits::ToString(event);
> On 2016/05/13 18:17:57, wjmaclean wrote:
> > I'm not sure I understand what this is here for?
> Oops, sorry. It's was just debug message. Removed.

I wondered about that :-) LGTM

[commit-bot: I haz the power, 2016-05-13 20:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 20:33:28]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-05-16 17:46:52]

sievers: ping?

[oshima, 2016-05-18 16:47:33]

oshima@chromium.org changed reviewers:
+ alexmos@chromium.org, tdresser@chromium.org
- sievers@chromium.org

[oshima, 2016-05-18 16:47:34]

tdresser@ -> c/b/renderer_host
alexmos@ -> c/b/frame_host

[tdresser, 2016-05-18 17:19:41]

LGTM

[alexmos, 2016-05-18 17:34:07]

LGTM

[oshima, 2016-05-18 17:46:50]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-05-18 17:47:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977513002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977513002/120001

[commit-bot: I haz the power, 2016-05-18 19:21:44]

Description was changed from

==========
Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes
the issue by only skip scaling when events are sent back from renderer.

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes
the issue by only skip scaling when events are sent back from renderer.

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-05-18 19:21:45]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-05-18 19:23:01]

Description was changed from

==========
Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes
the issue by only skip scaling when events are sent back from renderer.

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Disable input scaling only when an input came from renderer

I didn't realized that touch events are directly sent to guest views. This fixes
the issue by only skip scaling when events are sent back from renderer.

BUG=485650, 600453
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/cbcc58292dabf419324cddbad21242ddc8be3896
Cr-Commit-Position: refs/heads/master@{#394499}
==========

[commit-bot: I haz the power, 2016-05-18 19:23:02]

Patchset 2 (id:??) landed as
https://crrev.com/cbcc58292dabf419324cddbad21242ddc8be3896
Cr-Commit-Position: refs/heads/master@{#394499}