Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 1977513002: Disable input scaling only when an input came from renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_widget_host_view_guest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index b0f14abaa580e28792c0b5893f410e0b52464bf0..54d6c4c3875d8c0eabd4aa24dbb0081fad74c5fa 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -18,10 +18,12 @@
#include "cc/surfaces/surface_sequence.h"
#include "content/browser/browser_plugin/browser_plugin_guest.h"
#include "content/browser/compositor/surface_utils.h"
+#include "content/browser/renderer_host/input/input_router.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/renderer_host/render_widget_host_input_event_router.h"
#include "content/common/browser_plugin/browser_plugin_messages.h"
+#include "content/common/content_switches_internal.h"
#include "content/common/frame_messages.h"
#include "content/common/input/web_touch_event_traits.h"
#include "content/common/site_isolation_policy.h"
@@ -40,6 +42,29 @@
#endif
namespace content {
+namespace {
+
+class ScopedInputScaleDisabler {
+ public:
+ ScopedInputScaleDisabler(RenderWidgetHostImpl* host, float scale_factor)
+ : host_(host), scale_factor_(scale_factor) {
+ if (IsUseZoomForDSFEnabled())
+ host_->input_router()->SetDeviceScaleFactor(1.0f);
+ }
+
+ ~ScopedInputScaleDisabler() {
+ if (IsUseZoomForDSFEnabled())
+ host_->input_router()->SetDeviceScaleFactor(scale_factor_);
+ }
+
+ private:
+ RenderWidgetHostImpl* host_;
+ float scale_factor_;
+
+ DISALLOW_COPY_AND_ASSIGN(ScopedInputScaleDisabler);
+};
+
+} // namespace
RenderWidgetHostViewGuest::RenderWidgetHostViewGuest(
RenderWidgetHost* widget_host,
@@ -49,8 +74,6 @@ RenderWidgetHostViewGuest::RenderWidgetHostViewGuest(
// |guest| is NULL during test.
guest_(guest ? guest->AsWeakPtr() : base::WeakPtr<BrowserPluginGuest>()),
platform_view_(platform_view) {
- // Inputs for guest view are already scaled.
- host_->set_scale_input_to_viewport(false);
}
RenderWidgetHostViewGuest::~RenderWidgetHostViewGuest() {}
@@ -512,6 +535,7 @@ void RenderWidgetHostViewGuest::OnHandleInputEvent(
RenderWidgetHostImpl* embedder,
int browser_plugin_instance_id,
const blink::WebInputEvent* event) {
+ ScopedInputScaleDisabler disable(host_, current_device_scale_factor());
if (blink::WebInputEvent::isMouseEventType(event->type)) {
// The mouse events for BrowserPlugin are modified by all
// the CSS transforms applied on the <object> and embedder. As a result of
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698