src/frames-inl.h - Issue 19775017: Fix call stack sampling for the case when native callback invokes JS function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/frames-inl.h

Issue 19775017: Fix call stack sampling for the case when native callback invokes JS function (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixed test failure in debug mode Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/frames-inl.h

diff --git a/src/frames-inl.h b/src/frames-inl.h

index d097ed1dbb5e7a531bc9f1105168b95769b92ddd..2b15bfffab7a984a631e4e20fe3eec0dc06a0b0d 100644

--- a/src/frames-inl.h

+++ b/src/frames-inl.h

@@ -334,10 +334,10 @@ inline JavaScriptFrame* JavaScriptFrameIterator::frame() const {

}

-inline JavaScriptFrame* SafeStackFrameIterator::frame() const {

+inline StackFrame* SafeStackFrameIterator::frame() const {

ASSERT(!done());

- ASSERT(frame_->is_java_script());

- return static_cast<JavaScriptFrame*>(frame_);

+ ASSERT(frame_->is_java_script() || frame_->is_exit());

+ return frame_;

}

« no previous file with comments | « src/frames.cc ('k') | src/isolate.h » ('j') | no next file with comments »