Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: src/frames-inl.h

Issue 19775017: Fix call stack sampling for the case when native callback invokes JS function (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed test failure in debug mode Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.cc ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // TODO(1233797): The frame hierarchy needs to change. It's 327 // TODO(1233797): The frame hierarchy needs to change. It's
328 // problematic that we can't use the safe-cast operator to cast to 328 // problematic that we can't use the safe-cast operator to cast to
329 // the JavaScript frame type, because we may encounter arguments 329 // the JavaScript frame type, because we may encounter arguments
330 // adaptor frames. 330 // adaptor frames.
331 StackFrame* frame = iterator_.frame(); 331 StackFrame* frame = iterator_.frame();
332 ASSERT(frame->is_java_script() || frame->is_arguments_adaptor()); 332 ASSERT(frame->is_java_script() || frame->is_arguments_adaptor());
333 return static_cast<JavaScriptFrame*>(frame); 333 return static_cast<JavaScriptFrame*>(frame);
334 } 334 }
335 335
336 336
337 inline JavaScriptFrame* SafeStackFrameIterator::frame() const { 337 inline StackFrame* SafeStackFrameIterator::frame() const {
338 ASSERT(!done()); 338 ASSERT(!done());
339 ASSERT(frame_->is_java_script()); 339 ASSERT(frame_->is_java_script() || frame_->is_exit());
340 return static_cast<JavaScriptFrame*>(frame_); 340 return frame_;
341 } 341 }
342 342
343 343
344 } } // namespace v8::internal 344 } } // namespace v8::internal
345 345
346 #endif // V8_FRAMES_INL_H_ 346 #endif // V8_FRAMES_INL_H_
OLDNEW
« no previous file with comments | « src/frames.cc ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698