[compiler] Move list of inlined functions to Crankshaft.

[compiler] Move list of inlined functions to Crankshaft.

The data-structure in question is only used by Crankshaft, it can safely
be moved into the backend to avoid exposure through the CompilationInfo.

R=bmeurer@chromium.org

Committed: https://crrev.com/76569704569dafa3861c061359ef2bce860ab2c2
Cr-Commit-Position: refs/heads/master@{#36232}

[Benedikt Meurer, 2016-05-12 17:42:02]

LGTM modulo the memory leak.

https://codereview.chromium.org/1977473002/diff/1/src/crankshaft/hydrogen.h
File src/crankshaft/hydrogen.h (right):

https://codereview.chromium.org/1977473002/diff/1/src/crankshaft/hydrogen.h#n...
src/crankshaft/hydrogen.h:521: std::vector<HInlinedFunctionInfo>
inlined_function_infos_;
This has to be a ZoneVector, otherwise you leak the memory (as detected by ASAN
already).

[Michael Starzinger, 2016-05-13 08:32:48]

Thanks! Addressed comments.

https://codereview.chromium.org/1977473002/diff/1/src/crankshaft/hydrogen.h
File src/crankshaft/hydrogen.h (right):

https://codereview.chromium.org/1977473002/diff/1/src/crankshaft/hydrogen.h#n...
src/crankshaft/hydrogen.h:521: std::vector<HInlinedFunctionInfo>
inlined_function_infos_;
On 2016/05/12 17:42:02, Benedikt Meurer wrote:
> This has to be a ZoneVector, otherwise you leak the memory (as detected by
ASAN
> already).

Done. Absolutely right. I just blindly moved it without thinking, my fault. Our
tools are awesome. :)

[Michael Starzinger, 2016-05-13 10:31:40]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-05-13 10:31:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1977473002/#ps20001
(title: "Fix tha leeeek.")

[commit-bot: I haz the power, 2016-05-13 10:31:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977473002/20001

[commit-bot: I haz the power, 2016-05-13 10:33:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 10:34:24]

Description was changed from

==========
[compiler] Move list of inlined functions to Crankshaft.

The data-structure in question is only used by Crankshaft, it can safely
be moved into the backend to avoid exposure through the CompilationInfo.

R=bmeurer@chromium.org
==========

to

==========
[compiler] Move list of inlined functions to Crankshaft.

The data-structure in question is only used by Crankshaft, it can safely
be moved into the backend to avoid exposure through the CompilationInfo.

R=bmeurer@chromium.org

Committed: https://crrev.com/76569704569dafa3861c061359ef2bce860ab2c2
Cr-Commit-Position: refs/heads/master@{#36232}
==========

[commit-bot: I haz the power, 2016-05-13 10:34:25]

Patchset 2 (id:??) landed as
https://crrev.com/76569704569dafa3861c061359ef2bce860ab2c2
Cr-Commit-Position: refs/heads/master@{#36232}