Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1970193002: [compiler] Avoid passing CompilationInfo to profiler. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-sidechannel-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Avoid passing CompilationInfo to profiler. This completely removes any potential for a side-channel between the various compiler backends and the profiler. The CompilationInfo is no longer passed. R=yangguo@chromium.org Committed: https://crrev.com/c3cf2607f6c81d26a698747804f8c84fef9b1b59 Cr-Commit-Position: refs/heads/master@{#36230}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -30 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 2 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/log.h View 4 chunks +6 lines, -8 lines 0 comments Download
M src/log.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M src/profiler/cpu-profiler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/profiler/cpu-profiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-12 13:53:42 UTC) #1
Yang
_ _____ _______ __ __ | | / ____||__ __|| \/ | | | | ...
4 years, 7 months ago (2016-05-13 07:07:20 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1970193002/diff/1/src/compiler/ast-graph-builder.h File src/compiler/ast-graph-builder.h (right): https://codereview.chromium.org/1970193002/diff/1/src/compiler/ast-graph-builder.h#newcode18 src/compiler/ast-graph-builder.h:18: class CompilationInfo; On 2016/05/13 07:07:20, Yang wrote: > lol... ...
4 years, 7 months ago (2016-05-13 08:42:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970193002/1
4 years, 7 months ago (2016-05-13 09:43:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 09:44:58 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 09:46:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3cf2607f6c81d26a698747804f8c84fef9b1b59
Cr-Commit-Position: refs/heads/master@{#36230}

Powered by Google App Engine
This is Rietveld 408576698