Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5220)

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 19773012: [chromedriver] Accept loadAsync as a non-op chromeOption. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Accept but ignore loadAsync. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/capabilities.cc
diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc
index c331c97b6928f602a6ccb80e0f44e4f68ea99394..1a6854e4e6a948c4164edf618fb1d1b4b79f2372 100644
--- a/chrome/test/chromedriver/capabilities.cc
+++ b/chrome/test/chromedriver/capabilities.cc
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/callback.h"
+#include "base/logging.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
@@ -25,6 +26,14 @@ Status ParseDetach(
return Status(kOk);
}
+Status IgnoreDeprecatedOption(
+ const char* option_name,
+ const base::Value& option,
+ Capabilities* capabilities) {
+ LOG(WARNING) << "deprecated option is ignored:" << option_name;
kkania 2013/08/12 17:13:04 really this should go in the per session log
chrisgao (Use stgao instead) 2013/08/12 20:14:34 Done.
+ return Status(kOk);
+}
+
Status ParseChromeBinary(
const base::Value& option,
Capabilities* capabilities) {
@@ -180,6 +189,7 @@ Status ParseDesktopChromeCapabilities(
std::map<std::string, Parser> parser_map;
parser_map["detach"] = base::Bind(&ParseDetach);
+ parser_map["loadAsync"] = base::Bind(&IgnoreDeprecatedOption, "loadAsync");
parser_map["binary"] = base::Bind(&ParseChromeBinary);
parser_map["logPath"] = base::Bind(&ParseLogPath);
parser_map["args"] = base::Bind(&ParseArgs, false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698