[chromedriver] Accept loadAsync as a non-op chromeOption.

chrome/test/chromedriver/capabilities.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/capabilities.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/callback.h"
+#include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "chrome/test/chromedriver/chrome/status.h"
 
 namespace {
 
 typedef base::Callback<Status(const base::Value&, Capabilities*)> Parser;
 
 Status ParseDetach(
     const base::Value& option,
     Capabilities* capabilities) {
   if (!option.GetAsBoolean(&capabilities->detach))
     return Status(kUnknownError, "'detach' must be a boolean");
   return Status(kOk);
 }
 
+Status IgnoreDeprecatedOption(
+    const char* option_name,
+    const base::Value& option,
+    Capabilities* capabilities) {
+  LOG(WARNING) << "deprecated option is ignored:" << option_name;

[kkania, 2013/08/12 17:13:04]

really this should go in the per session log

[chrisgao (Use stgao instead), 2013/08/12 20:14:34]

Done.

+  return Status(kOk);
+}
+
 Status ParseChromeBinary(
     const base::Value& option,
     Capabilities* capabilities) {
   base::FilePath::StringType path_str;
   if (!option.GetAsString(&path_str))
     return Status(kUnknownError, "'binary' must be a string");
   base::FilePath chrome_exe(path_str);
   capabilities->command.SetProgram(chrome_exe);
   return Status(kOk);
 }
@@ skipping 135 matching lines @@
 Status ParseDesktopChromeCapabilities(
     const base::Value& capability,
     Capabilities* capabilities) {
   const base::DictionaryValue* chrome_options = NULL;
   if (!capability.GetAsDictionary(&chrome_options))
     return Status(kUnknownError, "'chromeOptions' must be a dictionary");
 
   std::map<std::string, Parser> parser_map;
 
   parser_map["detach"] = base::Bind(&ParseDetach);
+  parser_map["loadAsync"] = base::Bind(&IgnoreDeprecatedOption, "loadAsync");
   parser_map["binary"] = base::Bind(&ParseChromeBinary);
   parser_map["logPath"] = base::Bind(&ParseLogPath);
   parser_map["args"] = base::Bind(&ParseArgs, false);
   parser_map["prefs"] = base::Bind(&ParsePrefs);
   parser_map["localState"] = base::Bind(&ParseLocalState);
   parser_map["extensions"] = base::Bind(&ParseExtensions);
 
   for (base::DictionaryValue::Iterator it(*chrome_options); !it.IsAtEnd();
        it.Advance()) {
     if (parser_map.find(it.key()) == parser_map.end()) {
@@ skipping 108 matching lines @@
        it != parser_map.end(); ++it) {
     const base::Value* capability = NULL;
     if (desired_caps.Get(it->first, &capability)) {
       status = it->second.Run(*capability, this);
       if (status.IsError())
         return status;
     }
   }
   return Status(kOk);
 }