fix the incorrect logging of Translate.{NeverTranslateLang,NeverTranslateSite,AlwaysTranslateLang} …

fix the incorrect logging of Translate.{NeverTranslateLang,NeverTranslateSite,AlwaysTranslateLang} that always log 'true' instead of logging the correct value

BUG=556780
Committed: https://crrev.com/7e72639c2590b878205119cf515ca86f5cc8972f
Cr-Commit-Position: refs/heads/master@{#394485}

[ftang, 2016-05-13 22:18:35]

The CQ bit was checked by ftang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 22:19:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977143002/1

[ftang, 2016-05-13 22:19:47]

ftang@chromium.org changed reviewers:
+ groby@chromium.org

[commit-bot: I haz the power, 2016-05-13 23:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 23:38:05]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2016-05-17 22:20:46]

Be aware that this will cause incorrect readings as long as some clients report
the old way, and some the new way - essentially, Canary/Dev data for M52 for
these settings will be meaningless.

And timelines across versions will show a very marked change with M52. If you
want to avoid that, introduce new histogram names for the new way of measuring. 

Or, if those changes are not urgent, I'dsuggest postponing this change and  we
reconsider the metrics setup _in general_. I.e. do we want to break out by
language which are never/always translated, etc.

[ftang, 2016-05-17 22:59:26]

as long as we filter by the version, we will get the right vaule

[groby-ooo-7-16, 2016-05-18 17:46:01]

On 2016/05/17 22:59:26, ftang wrote:
> as long as we filter by the version, we will get the right vaule

Sure. (Well, except 52, which will have a mix in dev/canary)

LGTM if you're fine with that mix.

[ftang, 2016-05-18 17:46:39]

The CQ bit was checked by ftang@chromium.org

[commit-bot: I haz the power, 2016-05-18 17:46:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977143002/1

[commit-bot: I haz the power, 2016-05-18 18:57:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-18 18:59:47]

Description was changed from

==========
fix the incorrect logging of
Translate.{NeverTranslateLang,NeverTranslateSite,AlwaysTranslateLang} that
always log 'true' instead of logging the correct value

BUG=556780
==========

to

==========
fix the incorrect logging of
Translate.{NeverTranslateLang,NeverTranslateSite,AlwaysTranslateLang} that
always log 'true' instead of logging the correct value

BUG=556780

Committed: https://crrev.com/7e72639c2590b878205119cf515ca86f5cc8972f
Cr-Commit-Position: refs/heads/master@{#394485}
==========

[commit-bot: I haz the power, 2016-05-18 18:59:48]

Patchset 1 (id:??) landed as
https://crrev.com/7e72639c2590b878205119cf515ca86f5cc8972f
Cr-Commit-Position: refs/heads/master@{#394485}

[chaotian, 2016-05-18 20:50:10]

On 2016/05/18 17:46:01, groby wrote:
> On 2016/05/17 22:59:26, ftang wrote:
> > as long as we filter by the version, we will get the right vaule
> 
> Sure. (Well, except 52, which will have a mix in dev/canary)
> 
> LGTM if you're fine with that mix.

LGTM, this AlwaysTranslateLang is already going to be meaningless if we compare
old/new version, AlwaysTranslateLang was pretty small in old version since it is
hidden in options page, new UI moves it to the main dialog, and will
dramatically increase the count. The fix should bring logging better, since we
can now distinguish on/off.