Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: components/translate/core/browser/translate_ui_delegate.cc

Issue 1977143002: fix the incorrect logging of Translate.{NeverTranslateLang,NeverTranslateSite,AlwaysTranslateLang} … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_ui_delegate.cc
diff --git a/components/translate/core/browser/translate_ui_delegate.cc b/components/translate/core/browser/translate_ui_delegate.cc
index 26d1ead53f46d311ee0fd69c84d479c0df86cd5c..50879397171f0a66a0c9c50180aea59e27d7a43e 100644
--- a/components/translate/core/browser/translate_ui_delegate.cc
+++ b/components/translate/core/browser/translate_ui_delegate.cc
@@ -266,7 +266,7 @@ void TranslateUIDelegate::SetLanguageBlocked(bool value) {
prefs_->UnblockLanguage(GetOriginalLanguageCode());
}
- UMA_HISTOGRAM_BOOLEAN(kNeverTranslateLang, true);
+ UMA_HISTOGRAM_BOOLEAN(kNeverTranslateLang, value);
}
bool TranslateUIDelegate::IsSiteBlacklisted() {
@@ -293,7 +293,7 @@ void TranslateUIDelegate::SetSiteBlacklist(bool value) {
prefs_->RemoveSiteFromBlacklist(host);
}
- UMA_HISTOGRAM_BOOLEAN(kNeverTranslateSite, true);
+ UMA_HISTOGRAM_BOOLEAN(kNeverTranslateSite, value);
}
bool TranslateUIDelegate::ShouldAlwaysTranslate() {
@@ -320,7 +320,7 @@ void TranslateUIDelegate::SetAlwaysTranslate(bool value) {
else
prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang);
- UMA_HISTOGRAM_BOOLEAN(kAlwaysTranslateLang, true);
+ UMA_HISTOGRAM_BOOLEAN(kAlwaysTranslateLang, value);
}
std::string TranslateUIDelegate::GetPageHost() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698