Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Add missing helper function to CFX_ByteTextBuf to avoid the
anti-pattern CFX_ByteString(sBuf.AsStringC()), using the name
"Make" to indicate there's an allocation going on in this case.

Change some method arguments to take pre-existing ByteStrings where
possible.

Committed: https://pdfium.googlesource.com/pdfium/+/71a452f8ce12e31cc4e0d8c7878567b0c7fc63c2

[Tom Sepez, 2016-05-13 22:46:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-13 22:46:06]

Lei, for review.

[Tom Sepez, 2016-05-13 23:49:44]

Patchset #5 (id:80001) has been deleted

[Lei Zhang, 2016-05-13 23:49:55]

lgtm

https://codereview.chromium.org/1977093002/diff/60001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp (right):

https://codereview.chromium.org/1977093002/diff/60001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp:178: FX_BOOL
CPDF_SecurityHandler::LoadDict(CPDF_Dictionary* pEncryptDict,
For later - I wonder if the two CPDF_SecurityHandler::LoadDict() methods can be
combined.

https://codereview.chromium.org/1977093002/diff/60001/core/fpdfdoc/doc_basic.cpp
File core/fpdfdoc/doc_basic.cpp (right):

https://codereview.chromium.org/1977093002/diff/60001/core/fpdfdoc/doc_basic....
core/fpdfdoc/doc_basic.cpp:519: if (nPage > 0 && nPage <= nPages)
Ternary operator instead?

[Tom Sepez, 2016-05-14 00:28:46]

https://codereview.chromium.org/1977093002/diff/60001/core/fpdfdoc/doc_basic.cpp
File core/fpdfdoc/doc_basic.cpp (right):

https://codereview.chromium.org/1977093002/diff/60001/core/fpdfdoc/doc_basic....
core/fpdfdoc/doc_basic.cpp:519: if (nPage > 0 && nPage <= nPages)
On 2016/05/13 23:49:55, Lei Zhang wrote:
> Ternary operator instead?

Done.

[Tom Sepez, 2016-05-14 00:29:10]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-14 00:29:11]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1977093002/#ps100001
(title: "Rebase, nit")

[commit-bot: I haz the power, 2016-05-14 00:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977093002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977093002/100001

[commit-bot: I haz the power, 2016-05-14 00:51:31]

Description was changed from

==========
Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Add missing helper function to CFX_ByteTextBuf to avoid the
anti-pattern CFX_ByteString(sBuf.AsStringC()), using the name
"Make" to indicate there's an allocation going on in this case.

Change some method arguments to take pre-existing ByteStrings where
possible.
==========

to

==========
Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Add missing helper function to CFX_ByteTextBuf to avoid the
anti-pattern CFX_ByteString(sBuf.AsStringC()), using the name
"Make" to indicate there's an allocation going on in this case.

Change some method arguments to take pre-existing ByteStrings where
possible.

Committed:
https://pdfium.googlesource.com/pdfium/+/71a452f8ce12e31cc4e0d8c7878567b0c7fc...
==========

[commit-bot: I haz the power, 2016-05-14 00:51:31]

Committed patchset #5 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/71a452f8ce12e31cc4e0d8c7878567b0c7fc...