core/fpdfapi/fpdf_page/pageint.h - Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/pageint.h

Issue 1977093002: Make CFX_ByteString(const CFX_ByteStringC&) explicit. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/pageint.h

diff --git a/core/fpdfapi/fpdf_page/pageint.h b/core/fpdfapi/fpdf_page/pageint.h

index e904234e9f6571d50ac071f89fc59d5fade4425b..6534186dc8cb45d524546d0d394facf1c8e77953 100644

--- a/core/fpdfapi/fpdf_page/pageint.h

+++ b/core/fpdfapi/fpdf_page/pageint.h

@@ -155,7 +155,7 @@ class CPDF_StreamContentParser {

CPDF_Font* FindFont(const CFX_ByteString& name);

CPDF_ColorSpace* FindColorSpace(const CFX_ByteString& name);

CPDF_Pattern* FindPattern(const CFX_ByteString& name, bool bShading);

- CPDF_Object* FindResourceObj(const CFX_ByteStringC& type,

+ CPDF_Object* FindResourceObj(const CFX_ByteString& type,

const CFX_ByteString& name);

protected:

@@ -318,7 +318,7 @@ class CPDF_DocPageData {

void Clear(FX_BOOL bRelease = FALSE);

CPDF_Font* GetFont(CPDF_Dictionary* pFontDict, FX_BOOL findOnly);

- CPDF_Font* GetStandardFont(const CFX_ByteStringC& fontName,

+ CPDF_Font* GetStandardFont(const CFX_ByteString& fontName,

CPDF_FontEncoding* pEncoding);

void ReleaseFont(CPDF_Dictionary* pFontDict);

CPDF_ColorSpace* GetColorSpace(CPDF_Object* pCSObj,