Issue 19768003: Logger: remove dependency between Logger and LogMessageBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19768003: Logger: remove dependency between Logger and LogMessageBuilder. (Closed)

Created:
7 years, 5 months ago by loislo

Modified:
7 years, 5 months ago

Reviewers:
yurys, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Logger: remove dependency between Logger and LogMessageBuilder. LogMessageBuilder is a helper class for Log. So I made it a nested class and removed the dependency from Logger. BUG=none TEST=no changes in the logic R=yangguo@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15760

Patch Set 1 #

Patch Set 2 : header removed #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -122 lines)			Patch
M	src/log.h	View	1	4 chunks	+6 lines, -14 lines	0 comments	Download
M	src/log.cc	View	1	38 chunks	+49 lines, -55 lines	1 comment	Download
M	src/log-utils.h	View		2 chunks	+43 lines, -42 lines	0 comments	Download
M	src/log-utils.cc	View		8 chunks	+23 lines, -11 lines	0 comments	Download
M	test/cctest/test-log.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/19768003/diff/2001/src/log.cc File src/log.cc (right): https://codereview.chromium.org/19768003/diff/2001/src/log.cc#newcode945 src/log.cc:945: class CodeLogger { Delete this.

7 years, 5 months ago (2013-07-18 17:17:52 UTC) #3

loislo

7 years, 5 months ago (2013-07-18 17:19:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15760 (presubmit successful).

Expand Messages | Collapse Messages