Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2359)

Unified Diff: src/log.h

Issue 19768003: Logger: remove dependency between Logger and LogMessageBuilder. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: header removed Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/log.cc » ('j') | src/log.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 863f71d64b8b18afdd59058a89b61527c6ee1d5e..285d8734ba0e1d602f86f086d46df26090ab5977 100644
--- a/src/log.h
+++ b/src/log.h
@@ -31,7 +31,6 @@
#include "allocation.h"
#include "objects.h"
#include "platform.h"
-#include "log-utils.h"
namespace v8 {
namespace internal {
@@ -71,15 +70,15 @@ namespace internal {
// tick profiler requires code events, so --prof implies --log-code.
// Forward declarations.
-class LogMessageBuilder;
+class CompilationInfo;
+class CpuProfiler;
+class Isolate;
+class Log;
+class PositionsRecorder;
class Profiler;
class Semaphore;
-struct TickSample;
class Ticker;
-class Isolate;
-class PositionsRecorder;
-class CpuProfiler;
-class CompilationInfo;
+struct TickSample;
#undef LOG
#define LOG(isolate, Call) \
@@ -409,12 +408,6 @@ class Logger {
// Helper method. It dumps name into name_buffer_.
void AppendName(Name* name);
- // Appends standard code header.
- void AppendCodeCreateHeader(LogMessageBuilder*, LogEventsAndTags, Code*);
-
- // Appends symbol for the name.
- void AppendSymbolName(LogMessageBuilder*, Symbol*);
-
void RegisterSnapshotCodeName(Code* code, const char* name, int name_size);
// Emits a profiler tick event. Used by the profiler thread.
@@ -446,7 +439,6 @@ class Logger {
// private members.
friend class EventLog;
friend class Isolate;
- friend class LogMessageBuilder;
friend class TimeLog;
friend class Profiler;
template <StateTag Tag> friend class VMState;
« no previous file with comments | « no previous file | src/log.cc » ('j') | src/log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698