Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1976693002: Merge to 2704 "[DevTools] Do not reset page scale to 1.0, rely on setNeedsReset." (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge to 2704 "[DevTools] Do not reset page scale to 1.0, rely on setNeedsReset." > [DevTools] Do not reset page scale to 1.0, rely on setNeedsReset. > > Testing this would be nice, but the only idea I can come up with is > to call resetScaleStateImmediately() and check the page scale, > which is no good. > > BUG=603877 > > Review URL: https://codereview.chromium.org/1885043011 > > Cr-Commit-Position: refs/heads/master@{#387741} (cherry picked from commit 12ded61087cbef96393f56a6c01c8efcb386e4ef) TBR=pfeldman Committed: https://chromium.googlesource.com/chromium/src/+/1696148d976483a50ae1eb422511703b0a8462e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dgozman
4 years, 7 months ago (2016-05-12 18:57:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1696148d976483a50ae1eb422511703b0a8462e2 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698