Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1885043011: [DevTools] Do not reset page scale to 1.0, rely on setNeedsReset. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not reset page scale to 1.0, rely on setNeedsReset. Testing this would be nice, but the only idea I can come up with is to call resetScaleStateImmediately() and check the page scale, which is no good. BUG=603877 Committed: https://crrev.com/12ded61087cbef96393f56a6c01c8efcb386e4ef Cr-Commit-Position: refs/heads/master@{#387741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-04-15 20:40:33 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-04-15 21:24:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885043011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885043011/1
4 years, 8 months ago (2016-04-15 21:41:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 23:17:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:18:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12ded61087cbef96393f56a6c01c8efcb386e4ef
Cr-Commit-Position: refs/heads/master@{#387741}

Powered by Google App Engine
This is Rietveld 408576698