Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1976603006: Set view property of pointer events (Closed)

Created:
4 years, 7 months ago by Navid Zolghadr
Modified:
4 years, 7 months ago
Reviewers:
dtapuska, mustaq, Rick Byers
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set view property of pointer events Set view property of touch pointer events to its target's window and also set this view property while cloning them for boundary events. For mouse events it is already set from the corresponding mouse event. BUG=611053 Committed: https://crrev.com/79c4be60e6f02ca8fd9b982e1d057585e3784475 Cr-Commit-Position: refs/heads/master@{#393945}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties.html View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/touch-pointer-event-properties.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/mouse-pointer-event-properties-expected.txt View 1 2 13 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-event-properties-in-iframe.html View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/pointerevent/fast/events/pointerevents/pointer-event-properties-in-iframe-expected.txt View 6 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 1 2 4 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 2 5 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Navid Zolghadr
4 years, 7 months ago (2016-05-13 16:30:46 UTC) #2
dtapuska
lgtm % type of one argument https://codereview.chromium.org/1976603006/diff/1/third_party/WebKit/Source/core/events/PointerEventFactory.h File third_party/WebKit/Source/core/events/PointerEventFactory.h (right): https://codereview.chromium.org/1976603006/diff/1/third_party/WebKit/Source/core/events/PointerEventFactory.h#newcode41 third_party/WebKit/Source/core/events/PointerEventFactory.h:41: LocalDOMWindow*); This should ...
4 years, 7 months ago (2016-05-13 16:57:54 UTC) #3
Navid Zolghadr
https://codereview.chromium.org/1976603006/diff/1/third_party/WebKit/Source/core/events/PointerEventFactory.h File third_party/WebKit/Source/core/events/PointerEventFactory.h (right): https://codereview.chromium.org/1976603006/diff/1/third_party/WebKit/Source/core/events/PointerEventFactory.h#newcode41 third_party/WebKit/Source/core/events/PointerEventFactory.h:41: LocalDOMWindow*); On 2016/05/13 16:57:53, dtapuska wrote: > This should ...
4 years, 7 months ago (2016-05-16 13:34:41 UTC) #4
dtapuska
On 2016/05/16 13:34:41, Navid Zolghadr wrote: > https://codereview.chromium.org/1976603006/diff/1/third_party/WebKit/Source/core/events/PointerEventFactory.h > File third_party/WebKit/Source/core/events/PointerEventFactory.h (right): > > https://codereview.chromium.org/1976603006/diff/1/third_party/WebKit/Source/core/events/PointerEventFactory.h#newcode41 ...
4 years, 7 months ago (2016-05-16 13:37:20 UTC) #5
mustaq
lgtm
4 years, 7 months ago (2016-05-16 14:49:16 UTC) #6
Navid Zolghadr
4 years, 7 months ago (2016-05-16 14:49:44 UTC) #8
Rick Byers
LGTM
4 years, 7 months ago (2016-05-16 16:00:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976603006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976603006/20001
4 years, 7 months ago (2016-05-16 17:07:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/183772)
4 years, 7 months ago (2016-05-16 17:17:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976603006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976603006/40001
4 years, 7 months ago (2016-05-16 20:44:59 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-16 21:53:57 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:55:33 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/79c4be60e6f02ca8fd9b982e1d057585e3784475
Cr-Commit-Position: refs/heads/master@{#393945}

Powered by Google App Engine
This is Rietveld 408576698