third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp - Issue 1976603006: Set view property of pointer events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp

Issue 1976603006: Set view property of pointer events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/events/PointerEventFactory.cpp ('k') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp

diff --git a/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp b/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp

index 70be7599bf5e5057f2f3502b3a9816425d710fec..c8c0c9453764d966351c8551bb86ef355e723a42 100644

--- a/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp

+++ b/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp

@@ -88,7 +88,7 @@ void PointerEventFactoryTest::createAndCheckPointerTransitionEvent(

const AtomicString& type)

{

PointerEvent* clonePointerEvent = m_pointerEventFactory.

- createPointerTransitionEvent(pointerEvent, type, nullptr);

+ createPointerBoundaryEvent(pointerEvent, type, nullptr);

EXPECT_EQ(clonePointerEvent->pointerType(), pointerEvent->pointerType());

EXPECT_EQ(clonePointerEvent->pointerId(), pointerEvent->pointerId());

EXPECT_EQ(clonePointerEvent->isPrimary(), pointerEvent->isPrimary());

@@ -101,7 +101,7 @@ PointerEvent* PointerEventFactoryTest::createAndCheckTouchEvent(

PlatformTouchPoint::TouchState state)

{

PointerEvent* pointerEvent = m_pointerEventFactory.create(

- EventTypeNames::pointerdown, PointerEventFactoryTest::PlatformTouchPointBuilder(pointerType, rawId, state), PlatformEvent::NoModifiers, FloatSize(), FloatPoint());

+ EventTypeNames::pointerdown, PointerEventFactoryTest::PlatformTouchPointBuilder(pointerType, rawId, state), PlatformEvent::NoModifiers, FloatSize(), FloatPoint(), nullptr);

EXPECT_EQ(uniqueId, pointerEvent->pointerId());

EXPECT_EQ(isPrimary, pointerEvent->isPrimary());

return pointerEvent;