Use DiskCacheTestWithCache for DiskCachePerfTests.

Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliatuttle@chromium.org
BUG=611464
Committed: https://crrev.com/72043600e68cca36ab875e7275932d7355f79042
Cr-Commit-Position: refs/heads/master@{#393576}

[gavinp, 2016-05-12 19:07:49]

Julia: PTAL

[gavinp, 2016-05-12 19:28:20]

Patchset #2 (id:20001) has been deleted

[gavinp, 2016-05-12 20:36:32]

Description was changed from

==========
Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliattutle@chromium.org
BUG=611464
==========

to

==========
Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliatuttle@chromium.org
BUG=611464
==========

[gavinp, 2016-05-12 20:36:45]

gavinp@chromium.org changed reviewers:
+ juliatuttle@chromium.org
- juliattutle@chromium.org

[gavinp, 2016-05-12 20:36:57]

julia: I spelled your name correctly this time

[Julia Tuttle, 2016-05-13 16:37:14]

lgtm. (can we call them DiskCacheTestWithoutCache and DiskCacheTest instead? why
would there be one without a cache ever?)

[gavinp, 2016-05-13 17:55:00]

On 2016/05/13 16:37:14, Julia Tuttle wrote:
> lgtm. (can we call them DiskCacheTestWithoutCache and DiskCacheTest instead?
why
> would there be one without a cache ever?)

Thanks.

There's a lot wrong with disk cache testing, but yeah, this is one of them.
Maybe that name change makes sense. Or, just always have a cache; it's not like
the test is required to initialize it if it doesn't want it.

[gavinp, 2016-05-13 17:55:08]

The CQ bit was checked by gavinp@chromium.org

[commit-bot: I haz the power, 2016-05-13 17:55:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976513004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976513004/1

[commit-bot: I haz the power, 2016-05-13 18:00:34]

Description was changed from

==========
Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliatuttle@chromium.org
BUG=611464
==========

to

==========
Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliatuttle@chromium.org
BUG=611464
==========

[commit-bot: I haz the power, 2016-05-13 18:00:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-13 18:01:33]

Description was changed from

==========
Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliatuttle@chromium.org
BUG=611464
==========

to

==========
Use DiskCacheTestWithCache for DiskCachePerfTests.

All that manual cache initialization was noise and took away some
important convenience methods. This formulation significantly
simplifies the code.

R=juliatuttle@chromium.org
BUG=611464

Committed: https://crrev.com/72043600e68cca36ab875e7275932d7355f79042
Cr-Commit-Position: refs/heads/master@{#393576}
==========

[commit-bot: I haz the power, 2016-05-13 18:01:34]

Patchset 1 (id:??) landed as
https://crrev.com/72043600e68cca36ab875e7275932d7355f79042
Cr-Commit-Position: refs/heads/master@{#393576}